Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

make more links HTTPS #7297

Closed
diracdeltas opened this issue Feb 16, 2017 · 2 comments · Fixed by #7298
Closed

make more links HTTPS #7297

diracdeltas opened this issue Feb 16, 2017 · 2 comments · Fixed by #7298
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include security
Milestone
0.13.5

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Feb 16, 2017 •
edited by luixxiul
Loading

Test plan

#7298 (comment)

ex: https://dksfoto.smugmug.com/ for the background image link supports HTTPS
@diracdeltas diracdeltas added this to the 0.13.5 milestone Feb 16, 2017
@diracdeltas diracdeltas self-assigned this Feb 16, 2017
@diracdeltas
Copy link
Member Author

also some other HTTP urls that should be fixed

@diracdeltas diracdeltas changed the title link to newtab background image should be https make more links HTTPS Feb 16, 2017
diracdeltas added a commit that referenced this issue Feb 16, 2017
@diracdeltas
change links to HTTPS when possible
670d911 
fix #7297

Auditors: @bbondy

Test Plan:
1. open new tab
2. click on photographer link
3. it should open the photographer's website over HTTPS
@diracdeltas diracdeltas mentioned this issue Feb 16, 2017
Merged
@alexwykoff alexwykoff mentioned this issue Feb 26, 2017
Closed
@srirambv
Copy link
Collaborator

srirambv commented Feb 27, 2017 •
edited
Loading

Only working for PhotoSerge not on Darrell Sano's page
Edit: Works as expected

This was referenced Mar 1, 2017
Closed
Closed
Closed
Closed
This was referenced Mar 3, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include security
Projects
None yet
Milestone
0.13.5
Development

Successfully merging a pull request may close this issue.

change links to HTTPS when possible brave/browser-laptop
4 participants
@diracdeltas @alexwykoff @luixxiul @srirambv