This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
Fixed right click not dismissing / hiding an open menu (Windows only) #7403
Labels
Milestone
Comments
Correct, right click is not handled correctly. This bug was introduced with chromuim upgrade, @bbondy fixed it here da801c7. We should add the same fix here. But I think the core problem here is that the context menu wrapper is not handled correctly. You can see that blue box is much bigger then the context menu: This is because width and height is set to 100%. This properties were added in commit 064c55d. Because of that you don't have the same behavior if you click or hover on the left/right side of the menu (left side shows tab hover preview, right side does not): cc @bsclifton |
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Mar 12, 2017
Resolves brave#7403 Auditors: @bsclifton Test Plan: - specified in the issue brave#7403
This was referenced Mar 12, 2017
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Mar 12, 2017
Resolves brave#7403 brave#7662 Auditors: @bsclifton Test Plan: - specified in the issue brave#7403
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Mar 12, 2017
Resolves brave#7403 brave#7662 Auditors: @bsclifton Test Plan: - specified in the issue brave#7403
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Mar 12, 2017
Resolves brave#7403 brave#7662 Auditors: @bsclifton Test Plan: - specified in the issue brave#7403
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Mar 13, 2017
Resolves brave#7403 brave#7662 brave#1589 Auditors: @bsclifton Test Plan: - specified in the issue brave#7403
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Mar 26, 2017
Resolves brave#7403 brave#7662 brave#1589 Auditors: @bsclifton Test Plan: - specified in the issue brave#7403
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Mar 26, 2017
Resolves brave#7403 Resolves brave#7662 Resolves brave#1589 Auditors: @bsclifton Test Plan: - specified in the issue brave#7403
bsclifton
changed the title
Right click doesn't clear menu bar
Right click not dismissing / hiding an open menu (Windows only)
Apr 3, 2017
This was referenced Apr 9, 2017
This was referenced Apr 13, 2017
This was referenced Apr 21, 2017
alexwykoff
changed the title
Right click not dismissing / hiding an open menu (Windows only)
Fixed right click not dismissing / hiding an open menu
Apr 25, 2017
luixxiul
changed the title
Fixed right click not dismissing / hiding an open menu
Fixed right click not dismissing / hiding an open menu (Windows only)
Apr 26, 2017
@luixxiul those labels exist so the generator doesn't add them to the test runs. when i get a block of time i'll update the generator, but this is the SOP for now 😸 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Original title: Right click not dismissing / hiding an open menu (Windows only) #7403 (comment)
Test plan
#7661 (comment)
Hide the menu bar by default
, and confirm the menu shows upView
menu and wait for the menu to displaySee the GIF below (in this post) for what it looks like when it fails to close
Original issue description
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Right click doesn't clear menu bar
Platform (Win7, 8, 10? macOS? Linux distro?):
Windows 10 x64
Brave Version (revision SHA):
Brave 0.13.5
rev 7373a01
Steps to reproduce:
Actual result:
Menu item is not dismissed on right click
Expected result:
Should dismiss menu item when right click/left click
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
Yes
Can this issue be consistently reproduced?
Yes
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
cc: @NejcZdovc
The text was updated successfully, but these errors were encountered: