Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed new tab display when the window is small #7411

Closed
NejcZdovc opened this issue Feb 28, 2017 · 1 comment
Closed

Fixed new tab display when the window is small #7411

NejcZdovc opened this issue Feb 28, 2017 · 1 comment
Labels
feature/newtab QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.14.0

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 28, 2017 •
edited by luixxiul
Loading

Test Plan

#7415 (comment)

Original issue description

I sometimes use small music players (they are opened automatically in a new small window from their main page) like this one:

image

and if open a new tab, new tab is not adjusted for small window (window size in screen shots bellow is 560x680).

Current:
image

image

My proposition:
image

What do you think?

cc @bradleyrichter @luixxiul @cezaraugusto @bsclifton
@cezaraugusto
Copy link
Contributor

++ super cool

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 28, 2017
@NejcZdovc
Added mobile version for new tab
f459944 
Resolves brave#7411

Auditors: @cezaraugusto @bsclifton

Test Plan:
- open new tab
- resize window to 560x680
- there shouldn't be x scroll
@NejcZdovc NejcZdovc mentioned this issue Feb 28, 2017
Merged
4 tasks
@NejcZdovc NejcZdovc added this to the 0.13.6 milestone Feb 28, 2017
bsclifton added a commit that referenced this issue Mar 3, 2017
@bsclifton
Merge pull request #7415 from NejcZdovc/feature/#7411-new-tab
37bd986 
Added mobile version for new tab
This was referenced Mar 14, 2017
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 17, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Mar 21, 2017
Closed
@alexwykoff alexwykoff changed the title New tab small window Fixed new tab display when the window is small Mar 28, 2017
@alexwykoff alexwykoff mentioned this issue Mar 28, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/newtab QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
6 participants
@alexwykoff @luixxiul @cezaraugusto @bsclifton @NejcZdovc @srirambv