Fixed publishers are auto included even when auto-include sites is turned off

[srirambv]

Test Plan

• Enable payments in settings
• Disable auto-include switch
• Visit brianbondy.com in a new tab, site is added in the list and is not included

Automated test plan

• npm run test -- --grep="auto include"

Original issue description

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Publishers are auto included even when auto-include sites is turned off

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64

• Brave Version (revision SHA):
  Brave 0.13.5
  rev 0e68342

• Steps to reproduce:

  1. Enable payments in settings
  2. Disable auto-include switch
  3. Visit brianbondy.com in a new tab, site is added in the list and is auto included

• Actual result:
  Publishers are auto included even when auto-include sites is turned off

• Expected result:
  If auto-suggest is off then it should be set as disabled

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  No

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  

• Any related issues:
  Include switch is enabled by default for publishers even though auto include is turned off #7429
  cc: @mrose17 @cezaraugusto

[cezaraugusto]

Stepping back and assigning @mrose17

[mrose17]

@cezaraugusto - i think i understand what's going on here in enabledForSite at https://github.com/brave/browser-laptop/blob/master/app/renderer/components/preferences/ledgerTable.js#L51 the default return true should return the value of settings.advanced.auto-suggest-sites (not the exact syntax).

does that make sense to you?

[NejcZdovc]

@cezaraugusto also we need to change it here https://github.com/brave/browser-laptop/blob/master/app/renderer/components/preferences/ledgerTable.js#L101, we are sending true as default value

[srirambv]

+1 from community https://community.brave.com/t/auto-include-button-for-brave-payments-not-functioning-correctly/1674

[NejcZdovc]

@mrose17 I fixed this auto include problem, but I think that we have other problem as well. We don't set ledgerPayments to false, when we have auto include off. Which it the root cause for this "problem" (you can find updated code in #7680):

Publisher 1 (24ur.com): added when auto include was off
Publisher 2 (dailymotion.com): added when auto include was on
Publisher 3 (clifton.io): added when auto include was off, but then changed to include
Publisher 4 (slo-tech): added when auto include was off

When we add a publisher we don't set a value for the ledgerPayments, but we use default value based on auto include setting only when rendering (we don't save it). This means that when you toggle auto include sites include changes based on that.

My proposal
I would expect that if you have an auto include off, this should be saved into the store and can't be effected with a later change of auto include checkbox.

What do you think?

[mrose17]

@NejcZdovc - i agree!

cc: @bsclifton

[bsclifton]

Sounds good to me! I'll hold off on the merge until this is ready 😄