Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed advance settings button is blocked by helpful hints in certain situations #7452

Closed
srirambv opened this issue Mar 2, 2017 · 0 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Mar 2, 2017

Test plan

#7660 (comment)


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Advance Settings button hit area is blocked by helpful hints div when browser height is reduced

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.5
    rev 0e68342

  • Steps to reproduce:

    1. Set browser language to Russian
    2. Open settings page and reduce browser height so that helpful hints section is right below Advance settings
    3. Mouse over Advance settings, click is recognized only when the cursor is in the top half of the button
  • Actual result:
    Advance Settings button click area is blocked by helpful hints div when browser height is reduced

  • Expected result:
    Should not change the click area when helpful hints section is right below the advance settings button

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    hintsrussian

  • Any related issues:
    Helpful hints section shows scroll bars when screen size is reduced #7404
    cc: @cezaraugusto

@srirambv srirambv added this to the 0.13.6 milestone Mar 2, 2017
@srirambv srirambv added the l10n label Mar 2, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 12, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 12, 2017
Resolves brave#7452

Auditors:
@bsclifton @cezaraugusto

Test Plan:
- go to about:preferences
- switch to Russian
- advance settings should always be clickable
cezaraugusto pushed a commit that referenced this issue Mar 12, 2017
Resolves #7452

Auditors:
@bsclifton @cezaraugusto

Test Plan:
- go to about:preferences
- switch to Russian
- advance settings should always be clickable
@alexwykoff alexwykoff changed the title Advance Settings button click area is blocked by helpful hints div when browser height is reduced Fixed advance settings button is blocked by helpful hints in certain situations Mar 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.