Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed 'hide sites with <1% usage' should be default on in about:preferences#payments #7520

Closed
diracdeltas opened this issue Mar 7, 2017 · 4 comments
Closed

Fixed 'hide sites with <1% usage' should be default on in about:preferences#payments #7520

diracdeltas opened this issue Mar 7, 2017 · 4 comments
Assignees
@diracdeltas
Labels
feature/rewards QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.14.0

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Mar 7, 2017 •
edited by luixxiul
Loading

Test plan

#7522 (comment)

this would help make the page more manageable.
@diracdeltas diracdeltas added this to the 0.13.6 milestone Mar 7, 2017
@diracdeltas diracdeltas self-assigned this Mar 7, 2017
mrose17 added a commit that referenced this issue Mar 7, 2017
@mrose17
Initial check-in
49f1384 
Fixes #7520
@mrose17 mrose17 mentioned this issue Mar 7, 2017
Merged
4 tasks
@mrose17
Copy link
Member

mrose17 commented Mar 7, 2017

oops! i thought i had it...

@mrose17 mrose17 mentioned this issue Mar 8, 2017
Closed
This was referenced Mar 14, 2017
Closed
Closed
Closed
Closed
Closed
@alexwykoff
Copy link
Contributor

While the toggle is correct, the action does not appear to manifest properly.

(See last pub % in ledger)
categorizer_not_working

@srirambv
Copy link
Collaborator

This is what I see when I manually edit the ledger-synopsis.jsonfile. I think the condition is hide < 1% it should be more like hide <=1% that way the sites with 1% also gets hidden
7520

@diracdeltas
Copy link
Member Author

the original issue was just for sites with less than 1, not less or equal to 1.

This was referenced Mar 17, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff changed the title 'hide sites with <1% usage' should be default on in about:preferences#payments Fixed 'hide sites with <1% usage' should be default on in about:preferences#payments Mar 27, 2017
This was referenced Mar 28, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Mar 30, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
feature/rewards QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
5 participants
@mrose17 @diracdeltas @alexwykoff @luixxiul @srirambv