Re-enable DAU and MAU stats on Linux #7562
Comments
|
@aekeus if you want a break from addfunds I'd appreciate the help on this one |
|
Keeping in mind if this was a crash we don't want to re-introduce it: |
|
Ok, thanks. Will do. |
|
I am going to break this up to two issues. The first will be re-enabling the ping to the updater service. The second will be the notification in the update bar that a new version is available. |
This change re-enables the update check, used to send anonymous stats, for Linux.
The update check does not show the update bar, even if there is a newer version
of the software available. This will be addressed in a later commit.
Testing:
Testing this change from a QA perspective is problematic. These are the steps
I used to test the functionality of the change.
A)
* Change the version in package.json to a previous release version
* Build the binary on Linux
* Launch the browser ensuring:
* The browser does not crash on update init
* The updater scheduler is initiated
* Metadata is retrieved from the updater
* The updater bar is NOT shown
* The browser does not crash
* No attempt is made to update the browser binary
B)
* Change the browser version in package.json to a non-existent version
* Build on Linux and launch
* Ensure no metadata is retrieved
* Ensure that the ping is recorded in the dw.fc_usage table of stats
Auditors: @bbondy
Implements: #7562
|
@aekeus I tried setting version to 0.13.3 in package.json and found the following after launch:
Crash reporting enabled So it appears to be contacting the update server which the PR said should not be happening. This was on SHA : 77c562c |
|
That is the correct behaviour. We need to contact the update server to record the statistic (the metadata is retrieved as a no-op side effect). |
Test plan
#7651 (comment)
We should still do an update check, but change the messaging of the toolbar. Since 0.12.1 we aren't getting new update pings unless the user checks manually:
dcc4a8f
The text was updated successfully, but these errors were encountered: