On disable switch make the text grayed out

[srirambv]

Test plan

See #12455

Original issue description

• Did you search for similar issues before submitting this one?

• Describe the issue you encountered:

• Platform (Win7, 8, 10? macOS? Linux distro?):

• Brave Version (revision SHA):

• Steps to reproduce:
  1.
  2.
  3.

• Actual result:

• Expected result:

• Will the steps above reproduce in a fresh profile? If not what other info can be added?

• Is this an issue in the currently released version?

• Can this issue be consistently reproduced?

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:

• Any related issues:

[luixxiul]

Like this?

[srirambv]

Yes

[luixxiul]

CC @bradleyrichter for a comment

[bradleyrichter]

yes please

[bsclifton]

Should be easy to do- here's where you'd want to edit:
https://github.com/brave/browser-laptop/blob/master/app/renderer/components/settings.js#L41

[bbondy]

When would the switch be disabled?
This shouldn't be off state if that's what is meant.

[bsclifton]

@bradleyrichter would you want this grayed out when disabled? Or also when the switch is turned to off?

[NejcZdovc]

I would only grey out when checkbox is disabled

[bradleyrichter]

Correct. Only if a switch is disabled, not toggled off. I think we currently have few examples of this.

…

On Mar 11, 2017, at 11:16 PM, Nejc Zdovc ***@***.***> wrote: I would only grey out when checkbox is disabled — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[bsclifton]

Moving to 0.13.7

[cndouglas]

Example in Preferences > Plugins:

It looks like the shields panel already has this behavior:

[bsclifton]

Removing milestone

[chirag64]

I'd like to attempt a PR for this if no on else is working on it.

Is there any way to use the browser's Developer tools to debug the browser's UI? This would help me understand the code better and debug.

[luixxiul]

Shift+F8 activates the devtool ;-)

[user512]

Attached a screenshot in the pull request as well, thank you for reviewing. 😄

[srirambv]

Verified on Windows 10 x64 using

• 0.23.11 6565c06
• Muon 7.1.0
• libchromiumcontent 67.0.3396.87

Verified on Ubuntu 17.10 x64

• 0.23.12 - 88f6f07
• Muon - 7.1.1
• libchromiumcontent - 67.0.3396.87

Verified on macOS 10.13.4 x64 using the following build:

• 0.23.12 88f6f07
• muon: 7.1.1
• libchromiumcontent: 67.0.3396.87