Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

solve issue where black favicons on black tabs are invisible #7635

Closed
bradleyrichter opened this issue Mar 9, 2017 · 3 comments
Closed

solve issue where black favicons on black tabs are invisible #7635

bradleyrichter opened this issue Mar 9, 2017 · 3 comments

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Mar 9, 2017

Test plan:

#8373 (comment)


solution: use a webkit filter to add a glow around the image. (works on any shape)

image

image

image

code: -webkit-filter: drop-shadow(0px 0px 3px rgb(255, 255, 255));

@luixxiul
Copy link
Contributor

luixxiul commented Mar 9, 2017

I cannot remember well but @cezaraugusto has been notified this issue on github with a PR. Sorry if I'm worng

@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Mar 9, 2017
@cezaraugusto cezaraugusto self-assigned this Mar 11, 2017
@cezaraugusto
Copy link
Contributor

actually not solved yet but we can make use of CSS filters for this one

Sample: https://codepen.io/cezaraugusto/pen/QpvWzN

@bradleyrichter bradleyrichter modified the milestones: 0.14.1, 1.0.0 Mar 30, 2017
@bsclifton
Copy link
Member

Moving to 0.14.3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.