Fixed fresh install of Brave advertises Brave properties

[jonathansampson]

Test plan

#7753 (comment)

---

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  A fresh install of Brave yields advertisements for Brave. This took at least one user by surprise when they tried the browser. Their feedback is available on Twitter:

• Platform (Win7, 8, 10? macOS? Linux distro?):
  All

• Brave Version (revision SHA):
  0.13.5

• Steps to reproduce:

  1. Install Brave
  2. Type 'facebook' into address bar
  3. Brave auto-completes to 'facebook.com/brave'

• Actual result:
  Brave advertises its own properties on a fresh install.

• Expected result:
  User expects no advertisements or promotion

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  Yes

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:

  1. Steps repro for 'twitter'
  2. Steps repro for 'youtube'
  3. Steps repro for 'itunes'

#5594

[bsclifton]

Duplicate of #5892

cc: @bradleyrichter, @bbondy, @alexwykoff (in case we wanted to take action other than closing as a dupe)

[bradleyrichter]

This is the worst (or best) example of this "bug" and we should block on it. Of course this is a side effect of preloading top sites in the dashboard. In this example, the search result suggestion should not be pre-filled but rather presented in the list and require a down arrow to access. We may want to also create a new issue to mask out the preloaded top sites from the search suggestions so that this unintentional advertising is not perceived as intentional.

…

On Mar 11, 2017, at 8:48 PM, Brian Clifton ***@***.***> wrote: Duplicate of #5892 cc: @bradleyrichter, @bbondy, @alexwykoff (in case we wanted to take action other than closing as a dupe) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[diracdeltas]

Seems like the user is asking for the preloaded Brave sites to not be in the urlbar suggestions at all

[bsclifton]

@diracdeltas yup- we should be able to edit the site details to include a "leave me out of suggestions" flag. If the user then chooses to bookmark that site, we'd just want to clear that 😄

[bsclifton]

Reopening and removing milestone since the fix for this was reverted with e23e251

[luixxiul]

On the latest master on macOS I still see the URL.

I'm reopening the issue in case. Please close it if it is related with another issue, thanks.

[diracdeltas]

@luixxiul it works for me on master. do you have 23d813c ?

[luixxiul]

The branch was not updated, sorry for confusion!