Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added "Command+Click" to home button (opens home in a new background tab) #7718

Closed
bradleyrichter opened this issue Mar 15, 2017 · 5 comments
Closed

Added "Command+Click" to home button (opens home in a new background tab) #7718

bradleyrichter opened this issue Mar 15, 2017 · 5 comments
Assignees
@jonathansampson
Labels
feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Mar 15, 2017 •
edited by bsclifton
Loading

Test Plan

#7881 (comment)

  1. Turn on the Home button
  2. Ctrl+Click or Cmd+Click the Home button to open home page in a new tab
  3. Notice that tab will be opened in the background (ex: it's not active)

Original issue description

request from Twitter:

"My pet @brave peeve: command clicking on the home icon does not open a new tab. :("

Source: https://twitter.com/SambodhiPrem/status/841761765973086208

See chrome on Mac OS for reference)
@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Mar 15, 2017
@jonathansampson jonathansampson mentioned this issue Mar 25, 2017
Merged
4 tasks
@bsclifton bsclifton modified the milestones: 0.14.2, 1.0.0 Apr 3, 2017
This was referenced Apr 9, 2017
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor

luixxiul commented Apr 9, 2017 •
edited
Loading

Clicking the home button with the ctrl key opens the home page on the active tab.

Shouldn't it be opened on the background tab (as the title says)?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Apr 9, 2017
@jonathansampson
Copy link
Collaborator

@luixxiul You're correct. We differ with Chrome in that the new tab will immediately be focused in Brave, whereas it will not be focused in Chrome. @bsclifton, should we change?

@bsclifton
Copy link
Member

I support changing to match the Chrome behavior

@bradleyrichter what do you think? 😄

@bradleyrichter
Copy link
Contributor Author

bradleyrichter commented Apr 10, 2017 via email

bsclifton added a commit that referenced this issue Apr 11, 2017
@bsclifton
Update Ctrl+Home click or Cmd+Home click to open home page in backgro…
1c4b3c1 
…und tab, matching Chrome behavior

For more info, see discussion at #7718 (comment)

Auditors: @jonathansampson
@bsclifton bsclifton removed the needs-info Another team member needs information from the PR/issue opener. label Apr 11, 2017
@bsclifton
Copy link
Member

@luixxiul @jonathansampson @bradleyrichter updated! I also updated the test plan

This was referenced Apr 13, 2017
Closed
Closed
Closed
Closed
@jonathansampson jonathansampson mentioned this issue Apr 13, 2017
Closed
This was referenced Apr 21, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title Add "Command+Click" to home button (opens home in a new background tab) Added "Command+Click" to home button (opens home in a new background tab) Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonathansampson jonathansampson

Labels
feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
7 participants
@jonathansampson @alexwykoff @luixxiul @cezaraugusto @bsclifton @bradleyrichter @srirambv