Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

restructure paymentTab.js #7750

Closed
luixxiul opened this issue Mar 16, 2017 · 2 comments
Closed

restructure paymentTab.js #7750

luixxiul opened this issue Mar 16, 2017 · 2 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Mar 16, 2017

Test plan

#8237 (comment)

  1. Open about:preferences#sync
  2. Make sure "beta" is aligned top
  3. Open about:preferences#payments
  4. Make sure the labels appear the same row
  5. Make sure the switches and the labels are aligned exactly like Restructuring paymentsTab.js #7751

Ping @luixxiul for fixes in case the style becomes broken.


Refactored into this:

screenshot 2017-04-04 18 18 26

@luixxiul
Copy link
Contributor Author

luixxiul commented Apr 11, 2017

This regressed due to #8198 #8121

@luixxiul luixxiul self-assigned this Apr 11, 2017
@luixxiul
Copy link
Contributor Author

screenshot 2017-04-11 19 29 43

I'm going to address the issue by creating custom sectionTitle components, with Aphrodite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.