-
Notifications
You must be signed in to change notification settings - Fork 974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the upper line is a bit away. Please try to set it on "r", "m", "s" of "Brave payments", and the two switches. |
yeah I notice it as well, will fix soon. |
OK I slightly modified the positions. I'm not a fan of positioning with pixels (as it is often not compatible with other languages in terms of l10n), still it works in English on macOS, for now. IMO aligning all elements at center with |
@NejcZdovc now that your changes are merged, can you review this one? Thanks 😄 |
ok I will squash the commits at first. |
OK I added the test plan in the commit message and the 1st post. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #7750 - Removed 'pull-left', which is no longer used - Removed styles.titleBar - Created flexAlignCenter and flexAlignEnd as general properties - Replaced margin and padding with position:relative to set space between elements - Renamed advanceIcon to settingIcon - Changed the FAQ icons color to that on about pages (cf: about:preferences#plugins) Also: - Added globalStyles.fontSize.settingItemSubtext to global.js - Added commonTextColor to preferences.less - Added globalStyles.color.commonTextColor to global.js - Added autoSuggestSwitch__subtext Test Plan: 1. Open about:preferences#payments 2. Enable the payment 3. Make sure the switches, their labels and the buttons are aligned horizontally 4. Disable the payment 5. Make sure the switches and the labels are aligned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job
Closes #7750
Auditors:
Also:
Test Plan:
git rebase -i
to squash commits (if needed).Test Plan: