Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added context menu to Bookmarks Manager #7801

Closed
NejcZdovc opened this issue Mar 21, 2017 · 2 comments
Closed

Added context menu to Bookmarks Manager #7801

NejcZdovc opened this issue Mar 21, 2017 · 2 comments
Assignees
@NejcZdovc
Labels
feature/bookmarks feature/context-menu QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.14.0

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 21, 2017 •
edited by bsclifton
Loading

Test Plan

  • go to Bookmarks Manager
  • right click in a bookmarks area (right side)
  • select Add bookmark
  • bookmark dialog is opened

Original issue description

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    Add bookmark is not working in the context menu on a Bookmarks manager page

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    44d8279

  • Steps to reproduce:

    1. go to about:bookmarks
    2. right click in a bookmarks area (right side)
    3. select Add bookmark

  • Actual result:
    Noting happens

  • Expected result:
    Add bookmark dialog should be opened

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    yes

  • Can this issue be consistently reproduced?
    yes
@NejcZdovc NejcZdovc added this to the 0.14.1 milestone Mar 21, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 21, 2017
@NejcZdovc
Copy link
Contributor Author

@bsclifton should we add this to 0.14.0?

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 22, 2017
@NejcZdovc
Fixes Add Bookmarks in Bookmarks Manager
de0eac8 
Resolves brave#7801

Auditors: @bsclifton @darkdh

Test Plan:
- go to Bookmarks Manager
- right click in a bookmarks area (right side)
- select Add bookmark
- bookmark dialog is opened
@NejcZdovc NejcZdovc mentioned this issue Mar 22, 2017
Merged
4 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.14.0, 0.14.1 Mar 22, 2017
bsclifton added a commit that referenced this issue Mar 22, 2017
@bsclifton
Merge pull request #7829 from NejcZdovc/hotfix/#7801-bookmarks
cd2ab02 
Fixes Add Bookmarks in Bookmarks Manager
@bsclifton
Copy link
Member

@NejcZdovc yes- great catch (and thanks for the quick fix 😄 )

@alexwykoff alexwykoff mentioned this issue Mar 24, 2017
Closed
@alexwykoff alexwykoff changed the title Add bookmark context menu Added context menu to Bookmarks Manager Mar 24, 2017
This was referenced Mar 28, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Mar 30, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/bookmarks feature/context-menu QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
5 participants
@alexwykoff @luixxiul @bsclifton @NejcZdovc @srirambv