Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Integrate the new welcome screen #7821

Closed
bsclifton opened this issue Mar 21, 2017 · 6 comments
Closed

Integrate the new welcome screen #7821

bsclifton opened this issue Mar 21, 2017 · 6 comments
Assignees
@cezaraugusto
Labels
accessibility copy/content/text needs-info Another team member needs information from the PR/issue opener. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.17.13 (Release ...

Comments

@bsclifton
Copy link
Member

bsclifton commented Mar 21, 2017 •
edited by luixxiul
Loading

Test plan

#8097 (comment)

@cezaraugusto has worked with @bradleyrichter to deliver a beautiful new welcome screen (feel free to share details here)

The goal for this issue would be to integrate the screen into Brave. We'll want a new about:welcome or similarly named page which loads the content in an iframe.
@bsclifton bsclifton added this to the 0.14.1 milestone Mar 21, 2017
@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
@bsclifton
Copy link
Member Author

@bradleyrichter @cezaraugusto do you all have a link you can share for the welcome screen?

@cezaraugusto
Copy link
Contributor

fyi this page will be integrated by using an iframe on about:welcome

@cezaraugusto cezaraugusto mentioned this issue Apr 6, 2017
Merged
4 tasks
@bsclifton
Copy link
Member Author

Moving to 0.14.3

@bsclifton bsclifton modified the milestones: 0.14.3, 0.14.2 Apr 9, 2017
@alexwykoff alexwykoff modified the milestones: 0.15.4, 0.15.3 May 5, 2017
@cezaraugusto
Copy link
Contributor

after slack convo moving back to 0.15.3

@cezaraugusto cezaraugusto modified the milestones: 0.15.3, 0.15.4 May 5, 2017
cezaraugusto added a commit that referenced this issue May 8, 2017
@cezaraugusto
Add support for welcome page
4235b50 
- Auditors: @bsclifton
- Closes #7821
@cezaraugusto cezaraugusto modified the milestones: 0.15.4, 0.15.3 May 8, 2017
@bsclifton
Copy link
Member Author

bsclifton commented Jun 9, 2017 •
edited
Loading

@cezaraugusto @bradleyrichter the about:welcome page does exist now, but is there anything triggering it? (ex: first launch?)

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Jun 9, 2017
@cezaraugusto
Copy link
Contributor

only works if you go to about:welcome currently. @bradleyrichter may speak better what is expected. Maybe replace newtab page when first run after update/install happens and back to new tab for the next openings?

This was referenced Jun 19, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jun 19, 2017
Closed
@Jacalz Jacalz mentioned this issue Jun 21, 2017
Closed
94 tasks
@alexwykoff alexwykoff mentioned this issue Jun 22, 2017
Closed
@LaurenWags LaurenWags mentioned this issue Jun 23, 2017
Closed
@srirambv srirambv mentioned this issue Aug 16, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
accessibility copy/content/text needs-info Another team member needs information from the PR/issue opener. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

No branches or pull requests
6 participants
@alexwykoff @luixxiul @cezaraugusto @bsclifton @srirambv @LaurenWags