Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Updated UI for first time wallet creation #7889

Closed
srirambv opened this issue Mar 25, 2017 · 1 comment
Closed

Updated UI for first time wallet creation #7889

srirambv opened this issue Mar 25, 2017 · 1 comment
Assignees
Labels
design A design change, especially one which needs input from the design team. feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone

Comments

@srirambv
Copy link
Collaborator

srirambv commented Mar 25, 2017

Test plan

  • Clear profile and create a new one
  • Enable payments in the new profile
  • Make sure add funds button is already there

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    First time wallet creation causes some of the UI elements to be not shown until the wallet is created. This looks very unpolished(see screenshot)

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.14.0
    rev ffa6f8f

  • Steps to reproduce:

    1. Clear profile and create a new one
    2. Enable payments in the new profile
    3. UI looks bad
  • Actual result:
    First time wallet creation UI looks bad

  • Expected result:
    Should be more polished

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No since UI is different form 0.13.5

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    wallet_creation

  • Any related issues:
    cc: @mrose17 @bradleyrichter @NejcZdovc

@srirambv srirambv added design A design change, especially one which needs input from the design team. feature/rewards polish Nice to have — usually related to front-end/visual tasks. labels Mar 25, 2017
@srirambv srirambv added this to the 0.14.1 milestone Mar 25, 2017
@bradleyrichter
Copy link
Contributor

ok, the desired fix here is to show all elements when the screen redraws, but any elements that are not clickable should be disabled. (instead of hidden)

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 2, 2017
Resolves brave#7889

Auditors: @srirambv @bsclifton

Test Plan:
- Clear profile and create a new one
- Enable payments in the new profile
bsclifton added a commit that referenced this issue Apr 4, 2017
@alexwykoff alexwykoff changed the title First time wallet creation needs a better UI Updated UI for first time wallet creation Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Development

No branches or pull requests

7 participants