-
Notifications
You must be signed in to change notification settings - Fork 975
Browser crash when Brave Payments is enabled #7911
Comments
I tried it with the latest master on macOS and it's working correctly. Does it work on preview 6? |
Strange. I am looking at changes and nothing major was changed between 6 and 7 v0.14.0dev-Preview6...dev-channel Maybe node_modules removal or background page change? |
Crash reporting seems to be disabled for Windows build. I don't see console log as well when browser crashes |
macOS seems to have an issue too- Preview 7 is showing me the "Create wallet" button, even though I have payments enabled and I do indeed have a wallet. Here are logs from Windows (macOS gets the same underscore.trim() error):
|
|
|
it's listed as a dep for ledger-publisher and shows up in my local node_modules. It has also been there for a very long time. Maybe it was accidentally filtered in the changes @bbondy made? |
Turns out to be from "Ignore non first level node_modules", checking to see what we can do to keep it. |
thanks! |
Fixed now. It turns out we did have an underscore-string dep top level from argparse, but it was old, and it had a different directory hierarchy. It had trim under lib, and package.json specified that as the main entry The underscore.string that ledger-parser uses is newer and has the deps directly under underscore.string without a lib folder. By adding the dep top level, we can ensure we use the later version |
Auditors: @bridiver Fix #7911 It turns out we did have an underscore-string dep top level from argparse, but it was old, and it had a different directory hierarchy. It had trim under lib, and package.json specified that as the main entry point, but our electron resolver doesn't check that. The underscore.string that ledger-parser uses is newer and has the deps directly under underscore.string without a lib folder. By adding the dep top level, we can ensure we use the later version which doesn't have an extra directory that our resolver doesn't understand.
Auditors: @bridiver Fix #7911 It turns out we did have an underscore-string dep top level from argparse, but it was old, and it had a different directory hierarchy. It had trim under lib, and package.json specified that as the main entry point, but our electron resolver doesn't check that. The underscore.string that ledger-parser uses is newer and has the deps directly under underscore.string without a lib folder. By adding the dep top level, we can ensure we use the later version which doesn't have an extra directory that our resolver doesn't understand.
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Browser crash when Brave Payments is enabled
Platform (Win7, 8, 10? macOS? Linux distro?):
Windows 10 x64
Brave Version (revision SHA):
Brave 0.14.0
rev 61b6b6b
Steps to reproduce:
Actual result:
Browser crash when Brave Payments is enabled
Expected result:
Should not crash
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
No
Can this issue be consistently reproduced?
Yes
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
The text was updated successfully, but these errors were encountered: