Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor popupWindow.less with Aphrodite #7927

Closed
luixxiul opened this issue Mar 28, 2017 · 0 comments
Closed

Refactor popupWindow.less with Aphrodite #7927

luixxiul opened this issue Mar 28, 2017 · 0 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Mar 28, 2017

Test plan

#7929 (comment)


Describe the issue you encountered: Refactor popupWindow.less (used for extension dialogs) with Aphrodite

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:

@luixxiul luixxiul added this to the 0.14.1 milestone Mar 31, 2017
@luixxiul luixxiul modified the milestones: 0.14.3, 0.14.2 Apr 9, 2017
cezaraugusto pushed a commit that referenced this issue Apr 17, 2017
* Refactor popupWindow.less with Aphrodite

Also add right:1em to create margin between the pop up and the window right border

Closes #7927

Auditors:

Test Plan:
1. Open about:preferences#security
2. Enable LastPass
3. Click the extension icon on the navigation bar
4. Make sure you can log in your account

* update per @jonathansampson feedback
Auditors: @jonathansampson @luixxiul

* removes unecessary syles for popupWindow
Auditors: @luxxiul

* Improve code readability
Auditors: @jonathansampson
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.