Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed Sync losing hierarchy when adding bookmarks to new sync members #7971

Closed
alexwykoff opened this issue Mar 29, 2017 · 2 comments · Fixed by #8088
Closed

Fixed Sync losing hierarchy when adding bookmarks to new sync members #7971

alexwykoff opened this issue Mar 29, 2017 · 2 comments · Fixed by #8088
Assignees
@diracdeltas
Labels
bug feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.15.0

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Mar 29, 2017 •
edited by luixxiul
Loading

Test plan

#8088 (comment)

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When importing a lot of bookmarks, the top folder appears to be removed and the contents are imported instead.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X

  • Brave Version (revision SHA):
    0.14.0 RC2 (b00c5d9)

  • Steps to reproduce:

    1. With clean profiles on a machine
    2. Join an existing sync group with a lot of bookmarks ('forsaken' set for internal folks)
    3. Check structure of synced bookmarks, 'Lizard People... ' folder should be at the top

  • Actual result:
    The contents of the 'Lizard People...' folder are displayed and spread across the bookmarks toolbar

  • Expected result:
    There should be a singular 'Lizard People...' folder on the bookmarks toolbar

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Likely

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@alexwykoff alexwykoff added this to the 0.14.1 milestone Mar 29, 2017
@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
@diracdeltas diracdeltas self-assigned this Apr 3, 2017
diracdeltas added a commit that referenced this issue Apr 5, 2017
@diracdeltas
fix sync bookmarks hierarchy
28cda63 
fix #7971

Test Plan:
1. open pyramid 0, enable sync
2. bookmark bing.com
3. create a folder
4. move the bing bookmark into the folder
5. open pyramid 1, sync it to pyramid 0
6. a folder should appear in pyramid 1 with bing inside the folder
diracdeltas added a commit that referenced this issue Apr 5, 2017
@diracdeltas
fix sync bookmarks hierarchy
d577ec2 
fix #7971

Test Plan:
1. open pyramid 0, enable sync
2. bookmark bing.com
3. create a folder
4. move the bing bookmark into the folder
5. open pyramid 1, sync it to pyramid 0
6. a folder should appear in pyramid 1 with bing inside the folder
@diracdeltas diracdeltas mentioned this issue Apr 5, 2017
Merged
4 tasks
diracdeltas added a commit that referenced this issue Apr 5, 2017
@diracdeltas
fix sync bookmarks hierarchy
a3deceb 
fix #7971

Test Plan:
1. open pyramid 0, enable sync
2. bookmark bing.com
3. create a folder
4. move the bing bookmark into the folder
5. open pyramid 1, sync it to pyramid 0
6. a folder should appear in pyramid 1 with bing inside the folder
diracdeltas added a commit that referenced this issue Apr 5, 2017
@diracdeltas
fix sync bookmarks hierarchy
df0080e 
fix #7971

Test Plan:
1. open pyramid 0, enable sync
2. bookmark bing.com
3. create a folder
4. move the bing bookmark into the folder
5. open pyramid 1, sync it to pyramid 0
6. a folder should appear in pyramid 1 with bing inside the folder
This was referenced Apr 9, 2017
Closed
Closed
Closed
Closed
This was referenced Apr 13, 2017
Closed
Closed
Closed
@srirambv srirambv changed the title Sync is losing hierarchy when adding bookmarks to new sync members Fixed -Sync is losing hierarchy when adding bookmarks to new sync members Apr 13, 2017
This was referenced Apr 21, 2017
Closed
Closed
@alexwykoff
Copy link
Contributor Author

alexwykoff commented Apr 23, 2017 •
edited
Loading

Importing a set of bookmarks on Pyramid 0 still causes some hierarchy leakage on Pyramid 1 :
screen shot 2017-04-23 at 6 47 39 pm

@alexwykoff
Copy link
Contributor Author

There also appears to be a bit of an 'echo' which occurs on Pyramid 0:
screen shot 2017-04-23 at 6 51 14 pm

@luixxiul luixxiul changed the title Fixed -Sync is losing hierarchy when adding bookmarks to new sync members Fixed - Sync is losing hierarchy when adding bookmarks to new sync members Apr 24, 2017
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title Fixed - Sync is losing hierarchy when adding bookmarks to new sync members Fixed Sync losing hierarchy when adding bookmarks to new sync members Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

fix sync bookmarks hierarchy brave/browser-laptop
5 participants
@diracdeltas @alexwykoff @luixxiul @cezaraugusto @srirambv