This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
Fixed toggle excluding a site from ledger sometimes removes it from the list #7987
Labels
Milestone
Comments
diracdeltas
changed the title
toggle excluding a site from ledger removes it from the list
toggle excluding a site from ledger sometimes removes it from the list
Apr 1, 2017
from slack:
|
Assigning @NejcZdovc as he has looked into this issue the most (investigation still in progress) |
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Apr 4, 2017
Resolves brave#7987 Auditors: @mrose17 @diracdeltas Test Plan: - enable payments - visit site for at least 8 seconds or until it appears in the synopsis table - set minimum visits to 5 instead of 1 - site shouldn't be in the ledger table
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Apr 4, 2017
Resolves brave#7987 Auditors: @mrose17 @diracdeltas Test Plan: - enable payments - visit site for at least 8 seconds or until it appears in the synopsis table - set minimum visits to 5 instead of 1 - site shouldn't be in the ledger table
4 tasks
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Apr 4, 2017
Resolves brave#7987 Auditors: @mrose17 @diracdeltas Test Plan: - enable payments - visit site for at least 8 seconds or until it appears in the synopsis table - set minimum visits to 5 instead of 1 - site shouldn't be in the ledger table
diracdeltas
added a commit
that referenced
this issue
Apr 5, 2017
Fixes usage of ledger advance settings in the ledger table
This was referenced Apr 9, 2017
This was referenced Apr 13, 2017
This was referenced Apr 21, 2017
alexwykoff
changed the title
toggle excluding a site from ledger sometimes removes it from the list
Fixed toggle excluding a site from ledger sometimes removes it from the list
Apr 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test Plan
#8066 (comment)
Original issue description
mac os 0.14 and latest master
steps to repro (starting from a clean profile):
result:
nytimes.com suddenly disappears from the list when the switch is toggled
expected result:
when minimum visits is set to N, all sites with less than N visits should disappear immediately. the current behavior is very confusing because toggling the exclude switch should not remove the site from the list.
a similar issue exists for increasing the minimum time. if i increase it from 8 seconds to 1 minute, a site with 9 seconds remains in the ledger table. however if i then toggle the include switch on that site, it doesn’t disappear from the list, so the problem isn't as bad.
The text was updated successfully, but these errors were encountered: