This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
Fixed about pages cannot be synced because data is too big #8023
Labels
Milestone
Comments
I think we shouldn't sync |
diracdeltas
added a commit
that referenced
this issue
Apr 3, 2017
since they are likely to exceed the AWS upload limit. fix #8023 Test Plan: 1. unit tests should pass 2. set up sync 3. Open about:about and bookmark it 4. Open chrome-extension://cjnmeadmgmiihncdidmfiabhenbggfjm/_generated_background_page.html and wait. you should not see any errors related to encodeDataToS3KeyArray.
4 tasks
the max record size should be ~50 KiB. |
This was referenced Apr 9, 2017
This was referenced Apr 13, 2017
This was referenced Apr 21, 2017
alexwykoff
changed the title
About pages cannot be synced because data is too big (favicon is encoded in Base64 format)
Fixed about pages cannot be synced because data is too big
Apr 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Old title: About pages cannot be synced because data is too big (favicon is encoded in Base64 format) #8023 (comment)
Test plan
#8053 (comment)
Describe the issue you encountered:
Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32 bit
Brave Version (revision SHA): 0.14.1 RC1
Steps to reproduce:
Actual result: the error above is returned
Expected result: either favicon is replaced with a link or data limit is increased to sync the about pages
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
The text was updated successfully, but these errors were encountered: