Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Updated style for narrow tab audio indicator #8033

Closed
jonathansampson opened this issue Apr 2, 2017 · 0 comments
Closed

Updated style for narrow tab audio indicator #8033

jonathansampson opened this issue Apr 2, 2017 · 0 comments
Assignees
@jonathansampson
Labels
design A design change, especially one which needs input from the design team. feature/tabsbar polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Apr 2, 2017 •
edited by cezaraugusto
Loading

Test plan

#8035 (comment)

The current approach increases the tab's top-border, which pushes the favicon and title downward. This causes the affected tab's content to be misaligned with the content of neighboring tabs.

I suggest we use a pseudo-element on the tab instead, allowing the indicator-mark to be displayed without impacting the contents of the tab itself.

audio-indicator2
@jonathansampson jonathansampson added design A design change, especially one which needs input from the design team. feature/tabsbar polish Nice to have — usually related to front-end/visual tasks. labels Apr 2, 2017
@jonathansampson jonathansampson added this to the 0.14.2 milestone Apr 2, 2017
@jonathansampson jonathansampson self-assigned this Apr 2, 2017
@jonathansampson jonathansampson mentioned this issue Apr 2, 2017
Merged
4 tasks
This was referenced Apr 9, 2017
Closed
Closed
Closed
Closed
This was referenced Apr 13, 2017
Closed
Closed
Closed
This was referenced Apr 21, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title Use PseudoElement for Narrow-Tab Audio Indicator Updated style for narrow tab audio indicator Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonathansampson jonathansampson

Labels
design A design change, especially one which needs input from the design team. feature/tabsbar polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
5 participants
@jonathansampson @alexwykoff @luixxiul @cezaraugusto @srirambv