Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Use pseudo-element for audio indicator #8035

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Conversation

jonathansampson
Copy link
Collaborator

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #8033

Test Plan:

  1. Navigate to https://www.youtube.com/watch?v=WsSPW2oC7pI
  2. Open enough tabs to have 10 on-screen and reduce window-width to reveal player
  3. Toggle video pause/play state
  4. Tab contents should not shift when displaying the audio indicator

@jonathansampson jonathansampson added design A design change, especially one which needs input from the design team. feature/tabsbar polish Nice to have — usually related to front-end/visual tasks. labels Apr 2, 2017
@jonathansampson jonathansampson added this to the 0.14.2 milestone Apr 2, 2017
@jonathansampson jonathansampson self-assigned this Apr 2, 2017
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better, thanks for taking that +++

@cezaraugusto cezaraugusto merged commit 703e646 into master Apr 6, 2017
@cezaraugusto cezaraugusto deleted the tabs_play-indicator branch April 6, 2017 02:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/tabsbar polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants