You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
npm run test -- --grep="check pinned sites amount, when you have 0 eligible unpinned sites"
Did you search for similar issues before submitting this one?
yes
Describe the issue you encountered:
Calculation in the ledger table is wrong when you don't have any eligible unpinned sites and you set custom % for a pinned site that is bellow 100%.
Resolvesbrave#8102
Auditors: @mrose17@bradleyrichter
Test Plan:
- Go to payments and add two publishers
- Pin one and exclude the second one
- Set 60 % for a pinned publisher
- Value should be adjusted to 100%
Resolvesbrave#8102
Auditors: @mrose17@bradleyrichter
Test Plan:
- Go to payments and add two publishers
- Pin one and exclude the second one
- Set 60 % for a pinned publisher
- Value should be adjusted to 100%
Test Plan
#8103 (comment)
Automated test plan
npm run test -- --grep="check pinned sites amount, when you have 0 eligible unpinned sites"
Did you search for similar issues before submitting this one?
yes
Describe the issue you encountered:
Calculation in the ledger table is wrong when you don't have any eligible unpinned sites and you set custom % for a pinned site that is bellow 100%.
Platform (Win7, 8, 10? macOS? Linux distro?):
all
Brave Version (revision SHA):
7080042
Steps to reproduce:
Actual result:
Value stays the same, 60%
Expected result:
Value should be changed to 100%
Will the steps above reproduce in a fresh profile? If not what other info can be added?
yes
Is this an issue in the currently released version?
no
Can this issue be consistently reproduced?
yes
Screenshot if needed:
Any related issues:
Allow user to pin their favorite sites in Brave Payments (and other UI tweaks) #7347
The text was updated successfully, but these errors were encountered: