Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tearing off a tab causes the torn off site to display the wrong URL #8251

Closed
bsclifton opened this issue Apr 12, 2017 · 7 comments
Closed

Tearing off a tab causes the torn off site to display the wrong URL #8251

bsclifton opened this issue Apr 12, 2017 · 7 comments
Assignees
@bbondy
Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.15.0

Comments

@bsclifton
Copy link
Member

Steps to reproduce

  1. Have one window open with two tabs:
  1. Set some pinned tabs, if you don't already have any:
  • gmail.com
  • twitter.com
  1. make the window take up half of your screen width
  2. Drag the tab that has master out of the window. This creates a new window for the tab
  3. Notice the URL for the new tab has the URL of the last pinned
  4. Switch between the pinned tab and the main tab. Notice the URL stays the same
  5. Reload the tab (the not pinned one) and it will show the proper URL again
@bsclifton bsclifton added the bug label Apr 12, 2017
@bsclifton bsclifton added this to the 0.14.2 milestone Apr 12, 2017
@lukemulks
Copy link
Collaborator

FWIW @bsclifton & @bbondy I am unable to repro this in Windows 10 - 64bit

Tearoffs working well, and displaying the URL for the tab that has been torn off.

I've tried it with authenticated domains (Gmail), and Twitter (unauthenticated), and both display the proper URL in the tab that has been torn off.

Profile info below for reference:


Brave: 0.14.2 
rev: f07c1421b982ef66e4cd369e8d928a3f9b19ffd5 
Muon: 2.57.9 
libchromiumcontent: 57.0.2987.133 
V8: 5.7.492.71 
Node.js: 7.4.0 
Update Channel: dev 
os.platform: win32 
os.release: 10.0.14393 
os.arch: x64

@bsclifton
Copy link
Member Author

Reproduced on Windows and also found another interesting bug... will share a picture in a moment

@bsclifton
Copy link
Member Author

tear-off

@lukemulks
Copy link
Collaborator

Wild

64bit or 32bit Windows?

I've just tried reproducing again, and am seeing the appropriate URLs.

@bsclifton
Copy link
Member Author

@lukemulks 64-bit

@bbondy
Copy link
Member

bbondy commented Apr 12, 2017

I can reproduce np, @lukemulks maybe you didn't pin first? No worries in any case I have a fix I'm about to push.

bbondy added a commit that referenced this issue Apr 12, 2017
@bbondy
Update the correct frame's text on nav aborted
b770407 
Auditors: @bsclifton

Fix #8251

If a background tab event came in it would cause the active frame's input text to change.  This could have caused some intermittent strangeness in urlbar previously as well

The fix is to pass the frame path to update to updateNavBarInput so it
doesn't use the active frame.
@bbondy bbondy closed this as completed in fa7b57f Apr 12, 2017
@lukemulks
Copy link
Collaborator

lukemulks commented Apr 13, 2017 via email

This was referenced Apr 13, 2017
Closed
Closed
Closed
Closed
This was referenced Apr 21, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
7 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @lukemulks @srirambv