Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed tabs bar size by another 2 px based on increased user feedback #8263

Closed
bradleyrichter opened this issue Apr 12, 2017 · 1 comment
Closed

Fixed tabs bar size by another 2 px based on increased user feedback #8263

bradleyrichter opened this issue Apr 12, 2017 · 1 comment
Labels
design A design change, especially one which needs input from the design team. feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Apr 12, 2017 •
edited by bsclifton
Loading

Test plan

( should be tested on macOS, Linux, and Windows)

  1. Ensure themed tab option is turned on
  2. Visit some sites which have various coloring for tabs
  • github.com
  • facebook.com
  • about:preferences
  1. Make sure the tab looks good (text is readable, etc)
  2. Ensure drag and drop still works good for moving tabs around
  3. Ensure other features still look good; for example, bookmarks toolbar

Original issue description

Honestly, we have been increasing the tabs bar height by about 2 pixels every month or so, trying to keep the chrome footprint to a minimum stack height.

I believe higher-res laptops are creating taller toolbar requirements today than what was desired only a few years back.

Well, users want more tab height for usability. So, here you are users - another 2px. Enjoy. ; )
@bradleyrichter bradleyrichter added design A design change, especially one which needs input from the design team. feature/tabsbar labels Apr 12, 2017
@bradleyrichter bradleyrichter added this to the 0.14.2 milestone Apr 12, 2017
@jamesmudgett jamesmudgett mentioned this issue Apr 12, 2017
Merged
4 tasks
bsclifton pushed a commit that referenced this issue Apr 12, 2017
@jamesmudgett @bsclifton
Increase tabs bar height by 2px
99881bf 
Take some padding from bookmark bar

Fixes #8263
bsclifton pushed a commit that referenced this issue Apr 12, 2017
@jamesmudgett @bsclifton
Increase tabs bar height by 2px
4c77dcb 
Take some padding from bookmark bar

Fixes #8263
This was referenced Apr 13, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul reopened this Apr 13, 2017
@luixxiul
Copy link
Contributor

The fix will be like this, reserving the 7px margin between the top edge and the URL bar:

tab

@luixxiul luixxiul mentioned this issue Apr 13, 2017
Merged
4 tasks
bsclifton pushed a commit that referenced this issue Apr 13, 2017
@bsclifton
Increase the tabs bar and tabsToolbarButtons height
bc3259a 
Closes #8263

Auditors:

Test Plan:
1. Open github.com
2. Open facebook.com in a new tab
3. Open about:preferences in a new tab
4. Turn on the tab theme option
5. Make sure the tab looks good
6. Ensure drag and drop still works good for moving tabs around
7. Ensure other features still look good; for example, bookmarks toolbar
8. Ensure the menu button on the tabs bar still works good
This was referenced Apr 21, 2017
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title increase the tabs bar by another 2 px based on increased user feedback Fixed tabs bar size by another 2 px based on increased user feedback Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team. feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
7 participants
@jamesmudgett @alexwykoff @luixxiul @cezaraugusto @bsclifton @bradleyrichter @srirambv