Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed homepage preference isn't being respected #8278

Closed
alexwykoff opened this issue Apr 13, 2017 · 3 comments
Closed

Fixed homepage preference isn't being respected #8278

alexwykoff opened this issue Apr 13, 2017 · 3 comments

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Apr 13, 2017

Test plan

1cd536c


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When setting the homepage and then setting new tab to use homepage, it was found that the about:newtab was still being displayed. Quitting and restarting Brave did not alleviate the issue.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X

  • Brave Version (revision SHA):
    0.14.2 (f07c142)

  • Steps to reproduce:

    1. Open preferences, set homepage value
    2. Set new tab to open homepage
    3. Open a new tab with a keyboard (cmd+t)
  • Actual result:
    about:newtab is displayed

  • Expected result:
    your homepage should be displayed

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@alexwykoff alexwykoff added the bug label Apr 13, 2017
@alexwykoff alexwykoff added this to the 0.14.2 milestone Apr 13, 2017
@NejcZdovc NejcZdovc self-assigned this Apr 13, 2017
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 13, 2017

Can't reproduce this on dev-channel branch.

13

image

@srirambv
Copy link
Collaborator

Works fine on Windows with packaged build of preview 3

@NejcZdovc
Copy link
Contributor

Closing as can't reproduce, but if @alexwykoff you can still reproduce it please let me know and reopen this issue

@NejcZdovc NejcZdovc removed this from the 0.14.2 milestone Apr 13, 2017
@bsclifton bsclifton reopened this Apr 13, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 13, 2017
Resolves brave#8278

Auditors: @bsclifton

Test Plan:
- Open preferences, set homepage value
- Set new tab to open homepage
- Open a new tab with a keyboard (cmd+t)
@NejcZdovc NejcZdovc added this to the 0.14.2 milestone Apr 13, 2017
bsclifton pushed a commit that referenced this issue Apr 13, 2017
Resolves #8278

Auditors: @bsclifton

Test Plan:
- Open preferences, set homepage value
- Set new tab to open homepage
- Open a new tab with a keyboard (cmd+t)
@alexwykoff alexwykoff changed the title Homepage preference isn't being respected Fixed homepage preference isn't being respected Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.