Wallet creation fails on 0.14.2 RC build

[srirambv]

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Wallet creation fails on 0.14.2 RC build

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64

• Brave Version (revision SHA):
  Brave 0.14.2
  rev d4cad89

• Steps to reproduce:

  1. Do a clean install of 0.14.2 RC1 build
  2. Launch browser from git console
  3. Enable payments, console shows error, wallet creation fails

• Actual result:
  Wallet creation fails

• Expected result:
  Should create wallet

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  No

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  

! >>> worker error: Cannot find module 'node-anonize2-relic-emscriptenindex.js\./anonize2-jumbo.js'
ModuleNotFoundError: Cannot find module 'node-anonize2-relic-emscriptenindex.js\./anonize2-jumbo.js'
    at requireProxy (extensions::muon/module_system/commonjs:61:15)
    at fn (extensions::node-anonize2-relic-emscripten/index.js:3:16)
    at define (extensions::muon/module_system/commonjs:69:10)
    at Object.commonjs [as require] (extensions::muon/module_system/commonjs:54:3)
    at extensions::node-anonize2-relic-emscripten/index.js:325:43
    at requireProxy (extensions::muon/module_system/commonjs:64:22)
    at fn (extensions::ledger-client/worker.js:4:15)
    at define (extensions::muon/module_system/commonjs:69:10)
    at Object.commonjs [as require] (extensions::muon/module_system/commonjs:54:3)
    at extensions::ledger-client/worker.js:46:43
! >>> worker error: Cannot read property 'binding' of undefined
TypeError: Cannot read property 'binding' of undefined
    at requireProxy (extensions::muon/module_system/commonjs:65:20)
    at fn (extensions::ledger-client/worker.js:4:15)
    at define (extensions::muon/module_system/commonjs:69:10)
    at Object.commonjs [as require] (extensions::muon/module_system/commonjs:54:3)
    at extensions::ledger-client/worker.js:46:43

• Any related issues:
  Fixed wallet creation failure #8195

[lukemulks]

@srirambv confirming wallet creation hang on my Win10 64b install.

Enabling and disabling the Payments switch causes the Creating Wallet... message to hang, including on refresh.

Screencap below to illustrate:

Profile info for ref:

Brave: 0.14.2 
rev: d4cad892de4c8da087c4efee2e8955caa630675c 
Muon: 2.57.10 
libchromiumcontent: 57.0.2987.133 
V8: 5.7.492.71 
Node.js: 7.4.0 
Update Channel: dev 
os.platform: win32 
os.release: 10.0.14393 
os.arch: x64

[jonathansampson]

Same here, only mine locked up entirely.

Upon force-cancelling this process, I get the same output:

! >>> worker error: Cannot find module 'node-anonize2-relic-emscriptenindex.js\./anonize2-jumbo.js'
ModuleNotFoundError: Cannot find module 'node-anonize2-relic-emscriptenindex.js\./anonize2-jumbo.js'
    at requireProxy (extensions::muon/module_system/commonjs:61:15)
    at fn (extensions::node-anonize2-relic-emscripten/index.js:3:16)
    at define (extensions::muon/module_system/commonjs:69:10)
    at Object.commonjs [as require] (extensions::muon/module_system/commonjs:54:3)
    at extensions::node-anonize2-relic-emscripten/index.js:325:43
    at requireProxy (extensions::muon/module_system/commonjs:64:22)
    at fn (extensions::ledger-client/worker.js:4:15)
    at define (extensions::muon/module_system/commonjs:69:10)
    at Object.commonjs [as require] (extensions::muon/module_system/commonjs:54:3)
    at extensions::ledger-client/worker.js:46:43
! >>> worker error: Cannot read property 'binding' of undefined
TypeError: Cannot read property 'binding' of undefined
    at requireProxy (extensions::muon/module_system/commonjs:65:20)
    at fn (extensions::ledger-client/worker.js:4:15)
    at define (extensions::muon/module_system/commonjs:69:10)
    at Object.commonjs [as require] (extensions::muon/module_system/commonjs:54:3)
    at extensions::ledger-client/worker.js:46:43

I thought maybe npm install would resolve. It did not.

[bsclifton]

Fixed by reverting 91b8ebf

[bridiver]

I'm pretty sure this is the issue https://github.com/brave/ledger-client/blob/master/worker.js#L4
in general require shouldn't use .js extensions. require('node-anonize2-relic-emscripten') is sufficient and should fix the downstream path issue