This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixed wallet creation failure #8195
Assignees
Labels
Milestone
Comments
bbondy
added a commit
to brave/muon
that referenced
this issue
Apr 12, 2017
The directory was not being set correctly for packaged builds. In particular base::DIR_SOURCE_ROOT was returning a directory that wasn't correct. In dev builds it would return /Users/bbondy/projects/brave/browser-laptop-bootstrap/src/browser-laptop and in packaged builds that were run from /Users/bbondy/projects/brave/browser-laptop-bootstrap/src/browser-laptop/Brave-darwin-x64/Brave.app it would return /Users/bbondy/projects/brave/browser-laptop-bootstrap/src/. To fix this I just use the resource path's app.asar file if it exists first and only fallback to the search path if that doesn't exist since it only exists in packaged builds. Fix brave/browser-laptop#8195 Auditors: @bridiver
|
Fix is here: If accepted, we'll need new muon builds. |
bridiver
pushed a commit
to brave/muon
that referenced
this issue
Apr 12, 2017
The directory was not being set correctly for packaged builds. In particular base::DIR_SOURCE_ROOT was returning a directory that wasn't correct. In dev builds it would return /Users/bbondy/projects/brave/browser-laptop-bootstrap/src/browser-laptop and in packaged builds that were run from /Users/bbondy/projects/brave/browser-laptop-bootstrap/src/browser-laptop/Brave-darwin-x64/Brave.app it would return /Users/bbondy/projects/brave/browser-laptop-bootstrap/src/. To fix this I just use the resource path's app.asar file if it exists first and only fallback to the search path if that doesn't exist since it only exists in packaged builds. Fix brave/browser-laptop#8195 Auditors: @bridiver
This was referenced Apr 13, 2017
This was referenced Apr 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Old title: Wallet creation fails
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Wallet creation fails
Platform (Win7, 8, 10? macOS? Linux distro?):
All, @bsclifton confirmed on macOS
Brave Version (revision SHA):
Brave 0.14.2
rev 61ae1a7
Steps to reproduce:
Actual result:
Wallet creation fails
Expected result:
Wallet should be created
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
No
Can this issue be consistently reproduced?
Yes
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
Browser is responsive when anonize2 crypto operations run #7992
The text was updated successfully, but these errors were encountered: