Extension API: chrome.i18n.getAcceptLanguages

[jonathansampson]

https://developer.chrome.com/extensions/i18n#method-getAcceptLanguages

[cndouglas]

Related: #6818

[jonathansampson]

Blocks #8327

[jonathansampson]

Calling results in an Access to extension API denied message.

[jonathansampson]

@bsclifton I spoke with @bridiver about this; he suspects we could hook up much of (if not all?) chrome.i18n fairly easily. Assigning to him, per his request :)

[bsclifton]

Should be fixed with brave/muon@6853c9a

[jonathansampson]

Unfortunately, the PR doesn't resolve the issue. This method attempts to lift an array of preferred language codes from the user's profile preferences. If those aren't found, it looks to a flat preference file. Brave implements neither of these, and as such an empty list is returned.

ExtensionFunction::ResponseAction I18nGetAcceptLanguagesFunction::Run() {
  std::string accept_languages = Profile::FromBrowserContext(browser_context())
                                     ->GetPrefs()
                                     ->GetString(prefs::kAcceptLanguages);
  // Currently, there are 2 ways to set browser's accept-languages: through UI
  // or directly modify the preference file. The accept-languages set through
  // UI is guranteed to be valid, and the accept-languages string returned from
  // profile()->GetPrefs()->GetString(prefs::kAcceptLanguages) is guranteed to
  // be valid and well-formed, which means each accept-langauge is a valid
  // code, and accept-languages are seperatd by "," without surrrounding
  // spaces. But we do not do any validation (either the format or the validity
  // of the language code) on accept-languages set through editing preference
  // file directly. So, here, we're adding extra checks to be resistant to
  // crashes caused by data corruption.
  if (accept_languages.empty())
    return RespondNow(Error(kEmptyAcceptLanguagesError));

[darkdh]

what about setting user prefs intl.accept_languages in browser-laptop
just like https://github.com/brave/browser-laptop/blob/master/app/browser/reducers/spellCheckerReducer.js#L40

[bridiver]

@darkdh yes, that is what we need to set to make it work

[bsclifton]

@jonathansampson does this API work as expected? or was it re-opened because #14122 is still failing? (or both?)