Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

wallet creation fails on linux and macOS #8423

Closed
mrose17 opened this issue Apr 21, 2017 · 4 comments
Closed

wallet creation fails on linux and macOS #8423

mrose17 opened this issue Apr 21, 2017 · 4 comments
Assignees
@mrose17
Labels
feature/rewards OS/macOS OS/unix-like/linux QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.15.0

Comments

@mrose17
Copy link
Member

mrose17 commented Apr 21, 2017 •
edited by luixxiul
Loading

Test plan

#8423 (comment)

cf., #8372 (comment)
@mrose17 mrose17 added this to the 0.15.0 milestone Apr 21, 2017
@mrose17 mrose17 self-assigned this Apr 21, 2017
bsclifton pushed a commit that referenced this issue Apr 21, 2017
@mrose17 @bsclifton
Use latest ledger-client (and friends)
0e64cb3 
With the fix to a non-existent self.state.properties

Fixes #8423
@bbondy bbondy reopened this Apr 21, 2017
@bbondy
Copy link
Member

bbondy commented Apr 21, 2017

still failing

steps to reproduce:

  1. clear profile
  2. enable brave payments

Creating wallet hangs

This is using a build with tip:
0e64cb3

@bbondy
Copy link
Member

bbondy commented Apr 21, 2017

aka 0.15.0rc2

@NejcZdovc
Copy link
Contributor

tried on master as well and it's failing (tested on macOS)

@cezaraugusto
Copy link
Contributor

Still falling on RC2. Confirm bug happens on MacOS

STR:

  • With a fresh probile, go to payments
  • Enable payments
  • Loading state remains as-is forever (tested up to 7min)
  • Restart Brave
  • Go to payments
  • Click Create wallet button
  • Nothing happens

bsclifton pushed a commit that referenced this issue Apr 21, 2017
@mrose17 @bsclifton
Use ledger-client@0.9.15 and handle some timing issues
f553a8c 
Fixes #8423
@luixxiul luixxiul changed the title wallet creation fails on linux wallet creation fails on linux and macOS Apr 24, 2017
@luixxiul luixxiul mentioned this issue Apr 25, 2017
Closed
102 tasks
This was referenced Apr 25, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrose17 mrose17

Labels
feature/rewards OS/macOS OS/unix-like/linux QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
7 participants
@mrose17 @bbondy @alexwykoff @luixxiul @cezaraugusto @NejcZdovc @srirambv