Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tab context menus should offer "Mute all tabs" #8540

Open
bsclifton opened this issue Apr 27, 2017 · 3 comments
Open

Tab context menus should offer "Mute all tabs" #8540

bsclifton opened this issue Apr 27, 2017 · 3 comments

Comments

@bsclifton
Copy link
Member

Originally proposed in #8320, right clicking (or cmd + clicking) inside the tab area should bring up a context menu.

This should include "Mute All Tabs":
image

This should always mute all of the tabs. It was attempted in the PR, but @philkloose noticed that the quick implementation I did toggled the mute state (instead of muting all). When all are muted, we may consider changing the menu to "Unmute all"

cc: @bradleyrichter for more details 😄

@bsclifton
Copy link
Member Author

For reference, here is the implemenation I attempted with #8320

 +    {
 +      label: locale.translation('muteTabs'),
 +      click: () => {
 +        windowActions.muteAllAudio(generateMuteFrameList(framePropsList, true))
 +      }
 +    },

bsclifton added a commit to philkloose/browser-laptop that referenced this issue Apr 27, 2017
Mute all tabs moved functionality moved to brave#8540

Auditors: @philkloose
@bsclifton
Copy link
Member Author

@philkloose I assigned this to myself so that I can be available to help you 😄 Let me know if you have any questions or if you'd rather check a different issue out instead

philkloose added a commit to philkloose/browser-laptop that referenced this issue May 2, 2017
…Un)Mute Tab" always present, changed Mute icon display behavior.
@bradleyrichter bradleyrichter added this to the 0.15.400 milestone May 19, 2017
@bsclifton
Copy link
Member Author

removing milestone since the other fix was not merged

@bsclifton bsclifton removed this from the 0.16.100 milestone May 23, 2017
@bsclifton bsclifton removed their assignment May 23, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants