Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

When Brave Payment is enabled, accessing Shield Settings on a blank page will crash the browser #8545

Closed
onmyouji opened this issue Apr 28, 2017 · 1 comment
Closed

When Brave Payment is enabled, accessing Shield Settings on a blank page will crash the browser #8545

onmyouji opened this issue Apr 28, 2017 · 1 comment
Assignees
@bsclifton
Labels
crash feature/rewards feature/shields QA/test-plan-specified release-notes/include
Milestone
0.15.1

Comments

@onmyouji
Copy link

onmyouji commented Apr 28, 2017 •
edited by luixxiul
Loading

Test plan

https://github.com/bsclifton/browser-laptop/commit/d9745a52f10f6bb3660fb077781acea1195d4ee0

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When Brave Payment is enabled, accessing Site Shield Settings on a blank page will crash the browser.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Win7

  • Brave Version (revision SHA):
    0.15.0

  • Steps to reproduce:

    1. Enable "Brave Payments"
    2. Open a blank page (about:blank)
    3. Open "Site Shield Settings" from the menu

  • Actual result:
    Brave crash

  • Expected result:
    Shouldn't crash the browser. I've tested the above scenario with "Brave Payment" disabled, it doesn't crash.

  • Will the steps above reproduce in a fresh profile?
    Yes, I've uninstalled and reinstalled Brave.

  • Is this an issue in the currently released version?
    Yes, the latest one, 0.15.0

  • Can this issue be consistently reproduced?
    Yes
@bbondy bbondy added this to the 0.15.1 milestone Apr 28, 2017
@bsclifton bsclifton modified the milestones: 0.15.1, 0.15.2 Apr 28, 2017
@bsclifton bsclifton self-assigned this Apr 28, 2017
@cndouglas cndouglas mentioned this issue Apr 28, 2017
Closed
bsclifton added a commit that referenced this issue Apr 28, 2017
@bsclifton
Don't try to create tab if windowId is falsey
2450bac 
Fixes #8545

Auditors: @mrose17

Test plan:
1. Ensure Payments are enabled and Open `about:blank`
2. From the `Shields` menu, pick `Site Shield Settings...`
3. Verify nothing happens and that the app doesn't crash
@alexwykoff
Copy link
Contributor

about:blank simply shows a spinner on the tab and never completes, thus the shields menu is inaccessible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
crash feature/rewards feature/shields QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.1
Development

No branches or pull requests
5 participants
@bbondy @alexwykoff @luixxiul @bsclifton @onmyouji