Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Edit bookmark modal needs refactoring for UI scale #8634

Closed
srirambv opened this issue May 2, 2017 · 1 comment
Closed

Edit bookmark modal needs refactoring for UI scale #8634

srirambv opened this issue May 2, 2017 · 1 comment
Assignees
@luixxiul
Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite
Milestone
0.15.300 (Frozen,...

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 2, 2017 •
edited by luixxiul
Loading

Test plan

#8646 (comment)

  • Did you search for similar issues before submitting this one?

  • Describe the issue you encountered:

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version (revision SHA):

  • Steps to reproduce:

    1. Set UI scale to supersize
    2. Edit a bookmark from URL
    3. Bookmark modal is not properly refactored

  • Screenshot if needed:
    image

  • Any related issues:
@srirambv srirambv added design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. labels May 2, 2017
@luixxiul
Copy link
Contributor

luixxiul commented May 3, 2017 •
edited
Loading

I found it was not specific to the edit bookmark dialog; the bug exists on commonForm.js. I'm going to fix it.

#6040

@luixxiul luixxiul added bug refactoring/aphrodite and removed design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. labels May 3, 2017
@luixxiul luixxiul mentioned this issue May 3, 2017
Merged
4 tasks
luixxiul referenced this issue May 3, 2017
@cezaraugusto
prevent Dialog from being uncloseable with long text (#8475)
1ebea19 
* prevent Dialog from being uncloseable with long text
- Fix #7930
- Auditors: @luixxiul

* reopen
@luixxiul luixxiul added this to the 0.15.2 milestone May 3, 2017
This was referenced May 5, 2017
Closed
Closed
Closed
@luixxiul luixxiul self-assigned this May 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
3 participants
@alexwykoff @luixxiul @srirambv