Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix bookmark hanger dialog overflow #8646

Merged
merged 1 commit into from
May 5, 2017
Merged

Fix bookmark hanger dialog overflow #8646

merged 1 commit into from
May 5, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 3, 2017

Close #8634

Auditors:

Test Plan:

  1. Change UI scale on about:preferences#advanced
  2. Minimize the window size
  3. Click the star icon
  4. Make sure the hanger dialog is not broken

Test Plan 2:

  1. Open about:autofill
  2. Click "Add Address"
  3. Make sure the autofill dialog is not broken
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

@luixxiul luixxiul added this to the 0.15.2 milestone May 3, 2017
@luixxiul luixxiul self-assigned this May 3, 2017
@luixxiul luixxiul requested review from cezaraugusto and srirambv May 3, 2017 02:38
@luixxiul
Copy link
Contributor Author

luixxiul commented May 3, 2017

Also this PR should fix the overflow of commonForm mockup on about:styles.

Close #8634

Auditors:

Test Plan:
1. Change UI scale on about:preferences#advanced
2. Minimize the window size
3. Click the star icon
4. Make sure the hanger dialog is not broken

Test Plan 2:
1. Open about:autofill
2. Click "Add Address"
3. Make sure the autofill dialog is not broken
@NejcZdovc NejcZdovc requested review from NejcZdovc and removed request for cezaraugusto and srirambv May 5, 2017 15:55
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit f0ed2a1 into brave:master May 5, 2017
@luixxiul luixxiul deleted the fix-commonForm-width-height branch May 6, 2017 02:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants