This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Redux component - Menubar #8652

Closed

NejcZdovc opened this issue May 3, 2017 · 7 comments

Assignees

Labels

needs-info OS/Windows QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/include

Milestone

0.15.300 (Frozen,...

Contributor

NejcZdovc commented May 3, 2017 •

edited by luixxiul

Loading

Test plan

#8656 (comment)

Describe the issue you encountered:
Refactor Menubar into redux component.

The text was updated successfully, but these errors were encountered:

NejcZdovc added the refactoring/redux-component label

NejcZdovc added this to the 0.15.2 milestone

NejcZdovc self-assigned this

Member

bsclifton commented May 3, 2017 •

edited

Loading

I would vote to push this past 1.0 because it's very limited (only used on Windows; even then, only when menu is visible). I don't think we'd get much by reworking it

What do you think?

Contributor Author

NejcZdovc commented May 3, 2017

Sadly I need to refactor this, so that I can refactor #8651 and then when #8651 is refactored, #8640 will be fixed 😃

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors MenuBar and MenuBarItem into redux component

f5d7071

Resolves brave#8652

Auditors: @bsclifton @bridiver

Test Plan:
- open menu on windows
- try clicking around
- everything should behave as did before

NejcZdovc mentioned this issue

Refactors MenuBar and MenuBarItem into redux component #8656

Merged

4 tasks

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors MenuBar and MenuBarItem into redux component

db5ee4b

Resolves brave#8652

Auditors: @bsclifton @bridiver

Test Plan:
- open menu on windows
- try clicking around
- everything should behave as did before

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors MenuBar and MenuBarItem into redux component

Resolves brave#8652

Auditors: @bsclifton @bridiver

Test Plan:
- open menu on windows
- try clicking around
- everything should behave as did before

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors MenuBar and MenuBarItem into redux component

b8c397f

Resolves brave#8652

Auditors: @bsclifton @bridiver

Test Plan:
- open menu on windows
- try clicking around
- everything should behave as did before

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors MenuBar and MenuBarItem into redux component

e04031f

Resolves brave#8652

Auditors: @bsclifton @bridiver

Test Plan:
- open menu on windows
- try clicking around
- everything should behave as did before

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors MenuBar and MenuBarItem into redux component

7dcb919

Resolves brave#8652

Auditors: @bsclifton @bridiver

Test Plan:
- open menu on windows
- try clicking around
- everything should behave as did before

luixxiul added OS/Windows QA/test-plan-specified labels

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors MenuBar and MenuBarItem into redux component

5fc6dff

Resolves brave#8652

Auditors: @bsclifton @bridiver

Test Plan:
- open menu on windows
- try clicking around
- everything should behave as did before

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors MenuBar and MenuBarItem into redux component

ab6785a

Resolves brave#8652

Auditors: @bsclifton @bridiver

Test Plan:
- open menu on windows
- try clicking around
- everything should behave as did before

bsclifton closed this as completed in #8656

bsclifton added the release-notes/include label

Collaborator

bridiver commented May 5, 2017

sorry, but we need to revert this for now. It stores methods in the state and we can't do that because they are not serializable

Collaborator

bridiver commented May 5, 2017

I guess the menu template thing has been there for a long time so I'll leave this for now, but we need to fix that so I'll open a ticket

Contributor Author

NejcZdovc commented May 5, 2017

@bridiver yeah I listed this problem here #8528, because it would be overkill to refactor it in this PR. Problem is that the whole context menu is problematic and we need to find a better way to handle it.

This was referenced May 5, 2017

Generate Release Notes for 0.15.3 #8617

Closed

Per-release issue test for OS X 0.15.3 #8619

Closed

Manual tests for Windows x64 0.15.3 #8725

Closed

Manual tests for Linux 0.15.3 #8726

Closed

Contributor

luixxiul commented May 6, 2017

@bridiver @NejcZdovc so does this issue have to be reopened? I'm asking it for QA work.

luixxiul added the needs-info label

Contributor Author

NejcZdovc commented May 6, 2017

@luixxiul no need to be reopened, if you are talking about context menu, we will address this issue later on.

srirambv added the QA/checked-Win64 label

alexwykoff added the QA/checked-Linux label

alexwykoff added the QA/checked-macOS label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.