Browser crash with payment enabled when clearing browsing data

[srirambv]

Test plan

#8670 (comment)

---

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Browser crash with payment enabled when clearing browsing data

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64

• Brave Version (revision SHA):
  Brave 0.15.2
  rev 71f7dfd

• Steps to reproduce:

  1. Clean install 0.15.2 preview 2 and launch from console
  2. Clear browsing data, console shows error (screenshot 1)
  3. Enable payments, doesn't work(Wallet creation fails due to worker error  #8632)
  4. Kill the app and copy an old ledger-synopsis file and paste it in %appadata%
  5. Relaunch the app from console
  6. Enable payments, should work
  7. Clear browsing data, browser crahses (screenshot 2)

• Actual result:

• Expected result:

• Will the steps above reproduce in a fresh profile? If not what other info can be added?

• Is this an issue in the currently released version?

• Can this issue be consistently reproduced?

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  
  

• Any related issues:
  cc: @mrose17 @bsclifton

[bsclifton]

@srirambv the GIF moves too quick; can you please share the error message that is being seen?

Without being able to read the error, I am guessing this is related to the worker code and may be invalid with our next build

[srirambv]

@bsclifton here is the error. Sorry forgot to add it in the initial post

Clear private data error

$ Crash reporting enabled
An uncaught exception occurred in the main process Uncaught Exception:
TypeError: Insufficient number of arguments.
    at runCallback (timers.js:672:20)
    at tryOnImmediate (timers.js:645:5)
    at processImmediate [as _immediateCallback] (timers.js:617:5)
An uncaught exception occurred in the main process Uncaught Exception:
TypeError: Insufficient number of arguments.
    at runCallback (timers.js:672:20)
    at tryOnImmediate (timers.js:645:5)
    at processImmediate (timers.js:617:5)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)

Crash error

$ Crash reporting enabled
An uncaught exception occurred in the main process Uncaught Exception:
TypeError: Insufficient number of arguments.
    at runCallback (timers.js:672:20)
    at tryOnImmediate (timers.js:645:5)
    at processImmediate [as _immediateCallback] (timers.js:617:5)
C:\Users\Sriram BV\AppData\Local\brave\app-0.15.2\resources\app.asar\node_modules\node-anonize2-relic-emscripten\anonize2-jumbo.js:67
            throw ex
            ^

TypeError: Insufficient number of arguments.
    at runCallback (timers.js:672:20)
    at tryOnImmediate (timers.js:645:5)
    at processImmediate [as _immediateCallback] (timers.js:617:5)
~/AppData/Local/brave/Brave.exe

[darkdh]

only need to clear "all sites cookies" or "cached images and files"

[mrose17]

an observation: whenever i quit master on mac os, i see the same errors. the pointer into ...anonize2-jumbo.js:67 is misleading. that gets stuck on the stack regardless of whatever is going on...

i am investigating...

[mrose17]

@darkdh - very helpful, thanks!

[mrose17]

update: it appears to be related to 40abc0c

[bridiver]

there is an issue with the call to clearCache, but did this actually cause a crash? I saw the error on the console, but because it is called in setImmediate it didn't actually hurt anything other than not doing what it was supposed to do

[darkdh]

I can reproduce the crash in package build but not in dev environment.