Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Extension API: chrome.runtime.onInstalled.addListener #8685

Closed
jonathansampson opened this issue May 4, 2017 · 3 comments · Fixed by brave/muon#344
Closed

Extension API: chrome.runtime.onInstalled.addListener #8685

jonathansampson opened this issue May 4, 2017 · 3 comments · Fixed by brave/muon#344
Labels
feature/extensions priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/no-qa-needed release-notes/exclude

Comments

@jonathansampson
Copy link
Collaborator

https://developer.chrome.com/extensions/runtime#event-onInstalled

Blocks #8671

@jonathansampson jonathansampson mentioned this issue May 4, 2017
13 tasks
@jonathansampson jonathansampson changed the title Extension APIs: chrome.runtime.onInstalled.addListener Extension API: chrome.runtime.onInstalled.addListener Jul 3, 2017
@ghost ghost added this to the 0.20.x (Developer Channel) milestone Aug 30, 2017
@ghost
Copy link

ghost commented Aug 30, 2017

After discussion of progress on metamask integration items with @jonathansampson, adding this to the 0.20.x milestone.

@ghost ghost assigned jonathansampson Aug 30, 2017
@jonathansampson
Copy link
Collaborator Author

@kevinlawler Thoughts on this one? Do we presently have an event to hook-into?

@kevinlawler
Copy link
Contributor

The chrome.runtime.* libraries do not follow the same pattern for support that the previous libraries I've enabled have. I have spoken with @bridiver a little bit about this, and it seems like this logic will need to live in C++. For chrome.runtime.*, it looks like roughly half of the calls are currently enabled, some of them with exposed hooks through the JS. Many of the enabled chrome.runtime events live here

$BLB/src/extensions/renderer/resources/messaging.js

Unfortunately, if you search in that file there are no hits for onInstalled, which means it probably doesn't live there. Running chrome.runtime.onInstalled.addListener inside the console for an extension returns without error, but I have yet to verify that the functions passed to it are triggered at the correct time later on.

There are some hits for onInstalled here

$BLB/src/extensions/browser/api/runtime/runtime_api.cc

and this is probably a good place to begin looking to see how much of the code is live or dark.

@jonathansampson jonathansampson removed their assignment Sep 19, 2017
@ghost ghost added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 26, 2017
darkdh added a commit to brave/muon that referenced this issue Oct 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/extensions priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/no-qa-needed release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants