Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Minimizing the browser window leaves the tooltip open #8697

Closed
Jacalz opened this issue May 4, 2017 · 20 comments · Fixed by #10243
Closed

Minimizing the browser window leaves the tooltip open #8697

Jacalz opened this issue May 4, 2017 · 20 comments · Fixed by #10243

Comments

@Jacalz
Copy link
Contributor

Jacalz commented May 4, 2017

Test plan

  1. Open a window
  2. Minimize it with a fast click, don't wait for the tooltip to appear
  3. See that the tooltip DOES NOT show

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Originaly from the community but I can comfirm that I have the same issue 👍
    https://community.brave.com/t/minimizing-the-brave-browser-window-leaves-the-minimize-tooltop-balloon-up/2649
    The tooltip that says "Minimize" is still stuck on the screen after minimizing the browser window.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10

  • Brave Version (revision SHA):
    0.15.1

  • Steps to reproduce:

    1. Open a window
    2. Minimize it with a fast click, don´t wait for the tooltip to appear
    3. See that the tooltip still shows
  • Actual result:
    Tooltip is stuck on the screen

  • Expected result:
    Tooltip should fade away

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Will see later

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes
    brave

@Jacalz Jacalz changed the title Minimizing the windows leaves the tooltip open Minimizing the browser window leaves the tooltip open May 4, 2017
@luixxiul luixxiul added the bug label May 4, 2017
@jonathansampson
Copy link
Collaborator

@jonathansampson jonathansampson added this to the 1.0.0 milestone May 19, 2017
@legendarynacar
Copy link

I can confirm too. It is annoying. I can only prevent it with rightClick to top bar , selecting minimize. Or just dont minimze it and use alt+tab etc.

I hope you fix it soon.
Regards.

@jonathansampson
Copy link
Collaborator

@legendarynacar If you allow the tooltip to fully appear before clicking minimize, it will go away. You just need to hover over the button for 1-2 seconds before clicking.

@legendarynacar
Copy link

Yeah, it works as you said. But I am not used to wait. If I want to do something I just click and do. Why do I need to wait for it. No other programs has that problem. So it means they can fix it. I do not want to wait 1-2 for each time. Actually it is a lot of time if you imagine a workflow.

@luixxiul luixxiul added the needs-owner ♞ This issue is tagged for an upcoming release but has no owner. label May 23, 2017
@jonathansampson
Copy link
Collaborator

@legendarynacar We certainly aren't asking you to be okay with waiting; we will see to it that this issue is resolved in a future release. My advice was meant only as a way to handle this bug for the time being. I too minimize quickly, and often see that pesky tooltip linger.

@Foofy1
Copy link

Foofy1 commented Jun 17, 2017

+1
Wanted to add that I can avoid the bubble by minimizing via taskbar button.

@cndouglas
Copy link

+1 from #9599

@bsclifton
Copy link
Member

Looks like this may be an upstream issue; for more info see electron/electron#9943

It's reported in Chromium's tracker with https://bugs.chromium.org/p/chromium/issues/detail?id=724538

@bsclifton bsclifton added upstream and removed needs-owner ♞ This issue is tagged for an upcoming release but has no owner. labels Jul 11, 2017
@bsclifton bsclifton removed this from the 1.0.0 milestone Jul 11, 2017
@eljuno
Copy link
Contributor

eljuno commented Jul 14, 2017

+1 from community

@bsclifton
Copy link
Member

+1 from @bhuettmann via #10067 (minimize tooltip goes to the other monitor)

@Licenser
Copy link

+1 from here too and cheers for a wonderful description of the bug that was easy to find before reporting it again ;)

@Jacalz
Copy link
Contributor Author

Jacalz commented Jul 30, 2017

+1 from Degine on the community

@Jacalz
Copy link
Contributor Author

Jacalz commented Jul 30, 2017

@Jacalz
Copy link
Contributor Author

Jacalz commented Jul 30, 2017

+1 from bgonz on the community

@Jacalz
Copy link
Contributor Author

Jacalz commented Jul 30, 2017

@Jacalz
Copy link
Contributor Author

Jacalz commented Jul 30, 2017

@Jacalz
Copy link
Contributor Author

Jacalz commented Jul 30, 2017

+1 from jla on the community

@Jacalz
Copy link
Contributor Author

Jacalz commented Jul 30, 2017

Sorry for the spam but I had forgot to +1 a lot of comments 😅

@Jacalz
Copy link
Contributor Author

Jacalz commented Aug 1, 2017

@bsclifton bsclifton added this to the 0.18.x Hotfix milestone Aug 1, 2017
@bsclifton
Copy link
Member

bsclifton commented Aug 1, 2017

Because the underlying issue is in Chromium, I put together a fix we can use until that is fixed. The fix is to simply remove the tooltip. Under the hood, there is still an aria-label in the case that a screenreader is looking for information

Pull request is up here and (if approved) would be in our next release 😄

dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
…a-label

Fixes brave#8697

Auditors: @jonathansampson, @bradleyrichter

NOTE: this change goes against standard Windows behavior.
However, I did notice Firefox also doesn't show the tooltips on these buttons.

The root cause in our case (driving this commit) is captured here:
https://bugs.chromium.org/p/chromium/issues/detail?id=724538
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.