This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
URL parsing is slow #8707
Labels
Milestone
Comments
ayumi
added a commit
that referenced
this issue
May 4, 2017
Fix #8707 Auditors: @bsclifton @bbondy Test Plan: Make sure automated tests pass.
Merged
ayumi
added a commit
that referenced
this issue
May 5, 2017
Fix #8707 Test Plan: Make sure automated tests pass.
luixxiul
added
QA/required
QA/test-plan-specified
and removed
QA/test-plan-specified
QA/required
labels
This was referenced May 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
#8708 (comment)
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
While investigating URL bar slowness, I noticed
suggestion.simpleDomainNameValue()was slow. It callsurlParse()which usesurl.parse().When I replaced the node core implementation with
fast-url-parserit got way faster (10K bookmarks, first keystroke "a" from 2000 ms to 1500 ms).Platform (Win7, 8, 10? macOS? Linux distro?):
macOS
Brave Version (revision SHA):
c002e3f
The text was updated successfully, but these errors were encountered: