Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Replace all CSS and l10n selectors with data-test-id for webdriver tests #8735

Closed
cezaraugusto opened this issue May 6, 2017 · 0 comments · Fixed by #11912
Closed

Replace all CSS and l10n selectors with data-test-id for webdriver tests #8735

cezaraugusto opened this issue May 6, 2017 · 0 comments · Fixed by #11912
Labels
automated-tests QA/no-qa-needed refactoring/aphrodite release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented May 6, 2017 •
edited by luixxiul
Loading

Test plan

#11912 (comment)

This would ease the work of Aphrodite refactoring since we lose the option to tag components by CSS selector.

This work is split between unit tests and unit tests.

Related #8734
@cezaraugusto cezaraugusto mentioned this issue May 6, 2017
Closed
@cezaraugusto cezaraugusto changed the title Replace all CSS selectors with data-test-id for webdriver tests Replace all CSS and l10n selectors with data-test-id for webdriver tests May 6, 2017
luixxiul pushed a commit that referenced this issue Jul 4, 2017
Fix unittest errors
45fd298 
Addresses #8735

Test Plan: npm run unittest
luixxiul pushed a commit that referenced this issue Jul 4, 2017
Fix unittest errors
01ff951 
Addresses #8735

Test Plan: npm run unittest
luixxiul pushed a commit that referenced this issue Jul 4, 2017
Fix unittest errors
645d188 
Addresses #8735

Test Plan: npm run unittest
@luixxiul luixxiul mentioned this issue Sep 25, 2017
Closed
8 tasks
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Sep 26, 2017
@ghost ghost added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 26, 2017
@ghost ghost removed this from the 0.21.x (Nightly Channel) milestone Sep 26, 2017
@ghost ghost removed the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 26, 2017
This was referenced Oct 17, 2017
Merged
Closed
@luixxiul luixxiul mentioned this issue Nov 12, 2017
Merged
8 tasks
@luixxiul luixxiul added this to the 0.22.x (Nightly Channel) milestone Nov 14, 2017
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
This was referenced Jun 19, 2018
Closed
Closed
Closed
This was referenced Jun 21, 2018
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 25, 2018
Closed
Closed
Closed
This was referenced Jun 25, 2018
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
automated-tests QA/no-qa-needed refactoring/aphrodite release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Replace data-test-id
4 participants
@bbondy @kjozwiak @luixxiul @cezaraugusto