Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autoplay refactor #8847

Closed
darkdh opened this issue May 12, 2017 · 0 comments · Fixed by #8848
Closed

Autoplay refactor #8847

darkdh opened this issue May 12, 2017 · 0 comments · Fixed by #8848
Assignees
@darkdh
Labels
feature/autoplay QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@darkdh
Copy link
Member

darkdh commented May 12, 2017 •
edited by luixxiul
Loading

Test plan

#8848 (comment)

slack discussion

- Drop the shield setting
- Keep the notification bar
- Add the preloaded sites for youtube, twitch, etc
- Add an always always option like we have for fullscreen

#8739
@darkdh darkdh added this to the 0.15.300 milestone May 12, 2017
@darkdh darkdh self-assigned this May 12, 2017
darkdh added a commit that referenced this issue May 12, 2017
@darkdh
[WIP] Move autoplay to site setting
600a3a3 
fix #8847
@darkdh darkdh mentioned this issue May 12, 2017
Merged
6 tasks
@luixxiul luixxiul mentioned this issue May 12, 2017
Closed
4 tasks
darkdh added a commit that referenced this issue May 12, 2017
@darkdh
Autoplay refactor
1dc8459 
1. Move autoplay to site settings
2. Introduce built-in site settings

fix #8847

Auditors: @bbondy, @bsclifton

Test Plan:
Covered by webdriver test and unit test
bsclifton pushed a commit that referenced this issue May 15, 2017
@darkdh @bsclifton
Autoplay refactor
1e35477 
1. Move autoplay to site settings
2. Introduce built-in site settings

fix #8847

Auditors: @bbondy, @bsclifton

Test Plan:
Covered by webdriver test and unit test
This was referenced May 23, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/autoplay QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging a pull request may close this issue.

Autoplay refactor brave/browser-laptop
4 participants
@alexwykoff @luixxiul @darkdh @srirambv