Regression - importing cookies not working

[alexwykoff]

STR:

1. with a clean profile, launch the latest build of Brave 0.15.303
2. attempt to only import cookies from chrome / firefox

[darkdh]

It is not unresponsive of long running. The function on muon doesn't work due to brave/muon@d534ffd.
Functions of importing cookies from both Firefox and Chrome is broken.

[bridiver]

Import runs in a service worker so shouldn't make the browser unresponsive. The code is mostly just moved to accommodate the removal of patches, can you look into this @darkdh?

…

On May 13, 2017, at 10:13 PM, Anthony Tseng ***@***.***> wrote: It is not unresponsive of long running. The function on muon doesn't work due to ***@***.*** Functions of importing cookies from both Firefox and Chrome is broken. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

[bridiver]

along with process singleton this was a known possible regression with the patch cleanup

…

On May 13, 2017, at 10:13 PM, Anthony Tseng ***@***.***> wrote: It is not unresponsive of long running. The function on muon doesn't work due to ***@***.*** Functions of importing cookies from both Firefox and Chrome is broken. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

[darkdh]

I've already looked into it. almost done.

[luixxiul]

I'm not sure if this was really fixed.

STR:

1. Open chrome
2. Visit http://www.whatarecookies.com/cookietest.asp
3. Close chrome
4. Import cookie on Brave
5. Visit http://www.html-kit.com/tools/cookietester

Actual result: no existing cookie was found for this website

[darkdh]

It is expected. We can only import unencrypted cookies from Chrome. Unfortunately, the cookies we test are encrypted.
You can see the same behavior on Firefox. But you can try importing cookies from Firefox and see the cookie.

[srirambv]

You can see the same behavior on Firefox. But you can try importing cookies from Firefox and see the cookie.

@darkdh importing cookie from Firefox still doesn't show up on Brave

[darkdh]

@srirambv, you did clear cookies before importing so there is nothing to import. you must have cookies set in firefox first
try this http://www.html-kit.com/tools/cookietester