Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

new tab always shows about:blank #8850

Closed
diracdeltas opened this issue May 12, 2017 · 3 comments · Fixed by #8880
Closed

new tab always shows about:blank #8850

diracdeltas opened this issue May 12, 2017 · 3 comments · Fixed by #8880
Assignees
@diracdeltas
Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented May 12, 2017 •
edited by luixxiul
Loading

Test plan

opening a new tab (via cmd+t)

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    opening a new tab (via cmd+t) shows 'about:blank' instead of blank in the URL bar. I have the 'always show url bar' preference set.

OS X, 0.15.303
screen shot 2017-05-12 at 05 36 38
@diracdeltas diracdeltas added this to the 0.15.300 milestone May 12, 2017
@bsclifton
Copy link
Member

@diracdeltas is this the same as #8525 and/or #8378?

@diracdeltas
Copy link
Member Author

I don't think it's the same as #8525 because it happens when i hit cmd+t regardless of whether i have an about: tab open. It may be the same as #8378 except it happens all the time, not sporadically.

@diracdeltas diracdeltas changed the title new tab shows about:blank new tab always shows about:blank May 12, 2017
@alexwykoff
Copy link
Contributor

Initial launch with a clean profile shows the appropriate message of 'Enter a URL or search term' in the urlbar. Subsequent openings of new tabs are as described above.

This would also explain why it's missing a favicon when I open a lot of tabs. 😸

@luixxiul luixxiul added the bug label May 12, 2017
@diracdeltas diracdeltas self-assigned this May 15, 2017
diracdeltas added a commit that referenced this issue May 16, 2017
@diracdeltas
fix 'about:blank' being displayed permanently on new tabs
3caeeac 
fix #8850

Test Plan:
1. open several new tabs. they should all show blank in the urlbar instead of about:blank after a short lag.
2. 'new tab button' and 'new tab signal' tests should pass.
@diracdeltas diracdeltas mentioned this issue May 16, 2017
Merged
7 tasks
diracdeltas added a commit that referenced this issue May 16, 2017
@diracdeltas
fix 'about:blank' being displayed permanently on new tabs
f537cc3 
fix #8850

Test Plan:
1. open several new tabs. they should all show blank in the urlbar instead of about:blank after a short lag.
2. 'new tab button' and 'new tab signal' tests should pass.
@bsclifton bsclifton mentioned this issue May 16, 2017
Closed
This was referenced May 23, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging a pull request may close this issue.

fix 'about:blank' being displayed permanently on new tabs brave/browser-laptop
5 participants
@diracdeltas @alexwykoff @luixxiul @bsclifton @srirambv