Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autofill suggestion is way off when UI scale and default zoom is changed from default setting #8870

Closed
srirambv opened this issue May 15, 2017 · 13 comments
Closed

Autofill suggestion is way off when UI scale and default zoom is changed from default setting #8870

srirambv opened this issue May 15, 2017 · 13 comments
Assignees
@darkdh
Labels
bug feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 15, 2017 •
edited by luixxiul
Loading

Test plan

c36af01

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Autocomplete suggestion is way off

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.15.303
    rev 04ceba3

  • Steps to reproduce:

    1. Login/ Enter details in a input field to save auto suggestions
    2. Click on the input field to list the auto suggestions, position is way off

  • Actual result:
    Autocomplete suggestion is way off

  • Expected result:
    Should be below the input field

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image

  • Any related issues:
    cc: @darkdh
@srirambv srirambv added this to the 0.15.400 milestone May 15, 2017
@darkdh
Copy link
Member

darkdh commented May 15, 2017

This will be fixed by #8369

@darkdh darkdh closed this as completed May 15, 2017
@luixxiul luixxiul modified the milestones: 0.15.300, 0.15.400 May 15, 2017
@srirambv
Copy link
Collaborator Author

Still an issue on Windows.
image

@srirambv srirambv reopened this May 16, 2017
@darkdh darkdh self-assigned this May 16, 2017
@darkdh darkdh changed the title Autocomplete suggestion is way off Autofillsuggestion is way off May 16, 2017
@darkdh darkdh changed the title Autofillsuggestion is way off Autofill suggestion is way off May 16, 2017
@darkdh
Copy link
Member

darkdh commented May 16, 2017 •
edited
Loading

still can't reproduce on windows 10 with either package build or development build
screen shot 2017-05-16 at 4 55 59 pm
with 100, 125, 150, 175, 200 DPI

@luixxiul luixxiul added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label May 17, 2017
@luixxiul
Copy link
Contributor

luixxiul commented May 17, 2017 •
edited
Loading

@srirambv would you mind opening the devtool and paste the context menu div screenshot like this? It should be just under <div id="window">.

clipboard01

@srirambv
Copy link
Collaborator Author

@luixxiul
image

@bsclifton
Copy link
Member

bsclifton commented May 17, 2017 •
edited
Loading

Just so that we have the notes here: @darkdh did test at different DPI sizes without luck. He tested at 100%, 125%, 150%, 175%, 200%

@bsclifton
Copy link
Member

@srirambv are there any other steps you can think to try? In your screenshot, you have two tab pages. Does this matter?

@srirambv
Copy link
Collaborator Author

The root cause for the issue is the change in default zoom and UI scale. I had the UI scale set to Smaller and default zoom set to 90%.

@luixxiul luixxiul removed the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label May 17, 2017
@srirambv
Copy link
Collaborator Author

Changing either default zoom or UI scale causes the issue

@srirambv srirambv changed the title Autofill suggestion is way off Autofill suggestion is way off when UI scale and default zoom is changed from default setting May 17, 2017
@bsclifton
Copy link
Member

Great job narrowing this down, @srirambv 😄

@bradleyrichter
Copy link
Contributor

I think this may be related?

image

@bsclifton bsclifton modified the milestones: 0.15.400, 0.15.300 May 19, 2017
@bsclifton
Copy link
Member

Moving to 0.15.400 per conversation between @darkdh and @bbondy

@bsclifton
Copy link
Member

Seems to only happen when updating the Toolbar and UI elements scale; I can update the page zoom and nothing happens. Technically, this is just a bug, not a regression (since this functionality is new)
screen shot 2017-05-19 at 11 33 31 am

@bsclifton bsclifton added bug and removed regression labels May 19, 2017
@darkdh darkdh closed this as completed in c36af01 May 22, 2017
@bsclifton bsclifton modified the milestones: 0.15.300, 0.16.100 May 22, 2017
bsclifton pushed a commit that referenced this issue May 22, 2017
@darkdh @bsclifton
Fix coordinate calculation and apply toolbar UI scale to target element
f14d0d4 
fix #8870

Auditors: @bsclifton, @bbondy

Test Plan:
1. Go to about:preferences#advanced and change different UI scales
2. Go to any sites can trigger autofill popup or username/password popup
3. The context menu location should be just below the target element
This was referenced May 23, 2017
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue May 25, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
6 participants
@alexwykoff @luixxiul @bsclifton @darkdh @bradleyrichter @srirambv