Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

macOS copy issue is back #8876

Closed
bbondy opened this issue May 15, 2017 · 3 comments
Closed

macOS copy issue is back #8876

bbondy opened this issue May 15, 2017 · 3 comments

Comments

@bbondy
Copy link
Member

bbondy commented May 15, 2017

The macOS copy issue is back and we aren't sure why.
Both Clifton and I seen it independently.

I'm going to try reverting this old fix to see if it helps with the next packaged build:
6485cc5

Test Plan:

It's really hard to reproduce, but just be on the lookout on macOS for copy problems with keyboard shortcuts. It works via menu before and after this fix, but this is attempting to fix a command+C issue where text is inside a webview.

@bbondy
Copy link
Member Author

bbondy commented May 15, 2017

cc @diracdeltas FYI, please be on the lookout on the next preview. If you still see it, then we will revert the fix I do here, and then we'll have to search more for a different fix and re-open this.

bbondy added a commit that referenced this issue May 15, 2017
Recently we've been having an intermittent copy problem on macOS again that we haven't seen for a year.

To attempt to fix this we're going to revert an old hack that @diracdeltas did which held us until now

Fix #8876
@bbondy bbondy closed this as completed in 26afbd5 May 15, 2017
@luixxiul luixxiul added this to the 0.15.300 milestone May 15, 2017
@alexwykoff
Copy link
Contributor

@srirambv i have those 4 labels added because that is how our current test run generator works. until we have time to modify it, this is the proper practice 😄

@srirambv
Copy link
Collaborator

Sorry my bad. Since it was OS specific just added as QA Checked.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.