Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Find bar lose focus if tab is opened in a background #8877

Closed
NejcZdovc opened this issue May 15, 2017 · 0 comments · Fixed by #9426
Closed

Find bar lose focus if tab is opened in a background #8877

NejcZdovc opened this issue May 15, 2017 · 0 comments · Fixed by #9426
Assignees
@NejcZdovc
Labels
feature/findbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.19.x (Beta Chan...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented May 15, 2017 •
edited by luixxiul
Loading

Test plan

#9426 (comment)

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    Findbar lose focus if tab is opened in a background

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    26afbd5

  • Steps to reproduce:
    17
    (code: setTimeout(() =>appAction.createTabRequested({ url: 'https://www.brave.com', active: false }), 5000)

  • Actual result:
    find bar is focused out

  • Expected result:
    find bar keeps the focus

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    yes

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:

    1. BRAVE_TEST_COMMAND_LOGS=1 npm run test -- --grep="typing while another frame"
@NejcZdovc NejcZdovc added this to the 0.15.400 milestone May 15, 2017
@NejcZdovc NejcZdovc changed the title Focus is lost if tab is opened in a background Find bard focus lose if tab is opened in a background May 15, 2017
@NejcZdovc NejcZdovc changed the title Find bard focus lose if tab is opened in a background Find bard lose focus if tab is opened in a background May 15, 2017
@alexwykoff alexwykoff changed the title Find bard lose focus if tab is opened in a background Find bar lose focus if tab is opened in a background May 23, 2017
@alexwykoff alexwykoff modified the milestones: 0.16.200, 0.16.100 May 23, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.19.x (Nightly Channel), 0.18.x (Developer Channel) Jun 14, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 14, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 14, 2017
@NejcZdovc
Converts FindBar into redux component
5e8a0b9 
Resolves brave#9338
Resovles brave#8877

Auditors: @bsclifton @bridiver

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jun 14, 2017
Merged
8 tasks
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
This was referenced Sep 20, 2017
Closed
Closed
This was referenced Sep 21, 2017
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
@kjozwiak kjozwiak mentioned this issue Oct 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/findbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

Successfully merging a pull request may close this issue.

Converts FindBar into redux component NejcZdovc/browser-laptop
5 participants
@alexwykoff @luixxiul @NejcZdovc @srirambv @LaurenWags