-
Notifications
You must be signed in to change notification settings - Fork 975
about:safebrowsing shows a blank page #8905
Comments
on mac i see |
^ that was on latest master. on 15.304 i get the same thing as @luixxiul |
fix #8905 Test Plan: 1. safebrowsing test should pass 2. go to downloadme.org. it should redirect to the safebrowsing page and the page should not be blank or have missing text.
fix #8905 Test Plan: 1. safebrowsing test should pass 2. go to downloadme.org. it should redirect to the safebrowsing page and the page should not be blank or have missing text.
This appears to have regressed in 308 STR:
Expected result : about:safebrowsing is displayed appropriately Actual result : a blank page is displayed |
Works fine on Windows on a clean profile when opening with Ctrl+Click from http://alexwykoff.com/tests/testlinks.html |
@alexwykoff i think it's actually a separate issue, not a regression. the original issue was for links entered directly, not via cmd-click |
Since other cmd-click pages are working, is it reasonable to believe it is related? Clicks and cmd-clicks should be part of the test for this issue as well as simply entering downloadme.org into the urlbar. |
i agree the functionality should be tested; however @luixxiul's original issue showed that about:safebrowsing loaded but without text (due to the l10n library being blocked). the cmd+click issue shows nothing loaded at all |
k #9056 |
Test plan
#8923 (comment)
Describe the issue you encountered: about:safebrowsing shows shows a blank page
Platform (Win7, 8, 10? macOS? Linux distro?): debian
Brave Version (revision SHA): 0.15.304
Steps to reproduce:
about:safebrowsing#http://downloadme.org
)Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
The text was updated successfully, but these errors were encountered: