Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:safebrowsing shows a blank page #8905

Closed
luixxiul opened this issue May 17, 2017 · 9 comments · Fixed by #8923
Closed

about:safebrowsing shows a blank page #8905

luixxiul opened this issue May 17, 2017 · 9 comments · Fixed by #8923

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 17, 2017

Test plan

#8923 (comment)


Describe the issue you encountered: about:safebrowsing shows shows a blank page

  • Platform (Win7, 8, 10? macOS? Linux distro?): debian

  • Brave Version (revision SHA): 0.15.304

  • Steps to reproduce:

    1. Open downloadme.org
    2. blank
    3. Set focus to the URL bar (about:safebrowsing#http://downloadme.org)
    4. Hit Enter key
    5. loading is blocked
  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    clipboard01

    l20n.min.js Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
    aboutPages.entry.js Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
    
  • Any related issues:

@diracdeltas
Copy link
Member

on mac i see l120n.min.js blocked; the safebrowsing page shows up but not the text. it works if i reload the safebrowsing page.

@diracdeltas
Copy link
Member

^ that was on latest master. on 15.304 i get the same thing as @luixxiul

@diracdeltas diracdeltas self-assigned this May 17, 2017
diracdeltas added a commit that referenced this issue May 17, 2017
fix #8905

Test Plan:
1. safebrowsing test should pass
2. go to downloadme.org. it should redirect to the safebrowsing page and the page should not be blank or have missing text.
bsclifton pushed a commit that referenced this issue May 18, 2017
fix #8905

Test Plan:
1. safebrowsing test should pass
2. go to downloadme.org. it should redirect to the safebrowsing page and the page should not be blank or have missing text.
This was referenced May 25, 2017
@alexwykoff
Copy link
Contributor

This appears to have regressed in 308

STR:

  1. With a clean profile go to http://alexwykoff.com/tests/testlinks.html
  2. Use cmd + click to open the http://downloadme.org/ link in another tab

Expected result : about:safebrowsing is displayed appropriately

Actual result : a blank page is displayed

@luixxiul luixxiul changed the title about:safebrowsing shows shows a blank page about:safebrowsing shows a blank page May 25, 2017
@srirambv
Copy link
Collaborator

Works fine on Windows on a clean profile when opening with Ctrl+Click from http://alexwykoff.com/tests/testlinks.html

@diracdeltas
Copy link
Member

@alexwykoff i think it's actually a separate issue, not a regression. the original issue was for links entered directly, not via cmd-click

@alexwykoff
Copy link
Contributor

alexwykoff commented May 25, 2017

Since other cmd-click pages are working, is it reasonable to believe it is related?

Clicks and cmd-clicks should be part of the test for this issue as well as simply entering downloadme.org into the urlbar.

@alexwykoff
Copy link
Contributor

safebrowsing_click

@diracdeltas
Copy link
Member

i agree the functionality should be tested; however @luixxiul's original issue showed that about:safebrowsing loaded but without text (due to the l10n library being blocked). the cmd+click issue shows nothing loaded at all

@alexwykoff
Copy link
Contributor

k #9056

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.