Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

noscript exceptions applies non-http/https exceptions to all origins #8947

Closed
diracdeltas opened this issue May 19, 2017 · 1 comment · Fixed by #8969
Closed

noscript exceptions applies non-http/https exceptions to all origins #8947

diracdeltas opened this issue May 19, 2017 · 1 comment · Fixed by #8969
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude security
Milestone
0.15.300 (Frozen,...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented May 19, 2017 •
edited by luixxiul
Loading

Test plan

#8969 (comment)

in 0.15.304 and 0.15.305, i noticed that noscript works initially but stops working after a while. in 0.15.305, it worked when i installed it this morning but has now stopped working:
screen shot 2017-05-18 at 11 13 45 pm

i don't know exactly what made it stop working, but this has happened at least twice now
@diracdeltas diracdeltas added this to the 0.15.300 milestone May 19, 2017
@diracdeltas
Copy link
Member Author

i figured out the issue and it's not actually a regression; still pretty bad

@diracdeltas diracdeltas changed the title script blocking stops working after a while noscript exceptions applies non-http/https exceptions to all origins May 19, 2017
diracdeltas added a commit that referenced this issue May 20, 2017
@diracdeltas
fix noscript exception handling on file:/// URLs
a430d6a 
fix #8947
@diracdeltas diracdeltas mentioned this issue May 20, 2017
Merged
7 tasks
This was referenced May 23, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude security
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging a pull request may close this issue.

Fix problems with file:/// URLs brave/browser-laptop
5 participants
@diracdeltas @bbondy @alexwykoff @luixxiul @srirambv