Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

IME does not work properly on input form #9017

Closed
luixxiul opened this issue May 23, 2017 · 6 comments · Fixed by #9031
Closed

IME does not work properly on input form #9017

luixxiul opened this issue May 23, 2017 · 6 comments · Fixed by #9031
Assignees
@darkdh
Labels
bug l10n QA/checked-Linux QA/checked-macOS QA/test-plan-specified regression release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 23, 2017 •
edited
Loading

Test plan

  1. Enable IME (Japanese/Chinese/Korean/...) on your system
  2. Open about:autofill
  3. Select 'Add address'
  4. Hit some keys
  5. Make sure you are seeing the pulldown
  6. Hit Tab
  7. Make sure a conversion candidate is selected
  8. Hit Enter
  9. Make sure the candidate is decided

Describe the issue you encountered: IME does not work properly on input form. You cannot select a conversion candidate.
@luixxiul luixxiul added this to the 0.15.300 milestone May 23, 2017
@bsclifton
Copy link
Member

bsclifton commented May 23, 2017 •
edited
Loading

@luixxiul is this on master (as it states above)? or the last release candidate for 0.15.3xx? because they are very different at the moment. If this is on master only, please remove from this milestone (maybe push to the 0.16.100 milestone). Thanks 😄

@darkdh
Copy link
Member

darkdh commented May 24, 2017

confirm it occurs on autofill and bookmark dialog of 0.15.307

@luixxiul
Copy link
Contributor Author

luixxiul commented May 24, 2017 •
edited
Loading

@bsclifton I'm trying to find out since which release it is broken.

It works on:

  • .301
  • .302
  • .303

It does not work on .304

@luixxiul
Copy link
Contributor Author

@bsclifton @darkdh there should be the cause in here: v0.15.303dev...v0.15.304dev

@bsclifton
Copy link
Member

@luixxiul nice find! 😄 Thanks for narrowing it down

@bsclifton bsclifton reopened this May 24, 2017
@darkdh darkdh self-assigned this May 24, 2017
darkdh added a commit that referenced this issue May 24, 2017
@darkdh
Check input value before set it
3778688 
fix #9017

Auditors: @bsclifton, @bbondy

Test Plan:
1. Open editBookmark/autofill address/autofill credit card dialog
2. Make sure IME can input appropriately on text input value
@darkdh darkdh mentioned this issue May 24, 2017
Merged
7 tasks
darkdh added a commit that referenced this issue May 25, 2017
@darkdh
Check input value before set it
4652c1f 
fix #9017

Auditors: @bsclifton, @bbondy

Test Plan:
1. Open editBookmark/autofill address/autofill credit card dialog
2. Make sure IME can input appropriately on text input value
bsclifton pushed a commit that referenced this issue May 25, 2017
@darkdh @bsclifton
Check input value before set it
d30d5ff 
fix #9017

Auditors: @bsclifton, @bbondy

Test Plan:
1. Open editBookmark/autofill address/autofill credit card dialog
2. Make sure IME can input appropriately on text input value
bsclifton pushed a commit that referenced this issue May 25, 2017
@darkdh @bsclifton
Check input value before set it
4102e95 
fix #9017

Auditors: @bsclifton, @bbondy

Test Plan:
1. Open editBookmark/autofill address/autofill credit card dialog
2. Make sure IME can input appropriately on text input value
@luixxiul
Copy link
Contributor Author

confirmed it works on devian with ibus-mozc

@NejcZdovc NejcZdovc mentioned this issue Jun 16, 2017
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug l10n QA/checked-Linux QA/checked-macOS QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging a pull request may close this issue.

Check input value before set it brave/browser-laptop
4 participants
@alexwykoff @luixxiul @bsclifton @darkdh